Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't process a stale issue in the same run it's marked stale #696

Merged
merged 1 commit into from Apr 29, 2022

Conversation

luketomlinson
Copy link
Collaborator

Changes

We don't want to check for comments/updates if the issue/PR was just marked stale that run.

  • ...

Context

fixes #690

@luketomlinson luketomlinson requested a review from a team as a code owner March 17, 2022 13:41
@github-actions github-actions bot added the Stale label Apr 17, 2022
@github-actions github-actions bot closed this Apr 22, 2022
@luketomlinson luketomlinson reopened this Apr 22, 2022
@github-actions github-actions bot closed this Apr 28, 2022
@luketomlinson luketomlinson reopened this Apr 28, 2022
// Should we un-stale this issue?
if (shouldRemoveStaleWhenUpdated && issueHasComments) {
if (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we could just else if here and remove !issue.markedStaleThisRun

thboop
thboop approved these changes Apr 28, 2022
Copy link
Contributor

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luketomlinson luketomlinson merged commit 65d24b7 into main Apr 29, 2022
13 checks passed
@luketomlinson luketomlinson deleted the bugfix/stale-mutually-exclusive branch April 29, 2022 14:07
@Gustry
Copy link

Gustry commented May 20, 2022

Thanks for this fix. Is-it possible to make a release ?

@Ryan9Manu
Copy link

Jighbb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale action erroneously removed the stale label
4 participants