Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(options): add missing close-issue-reason option #772

Merged

Conversation

plainheart
Copy link
Contributor

@plainheart plainheart commented Jul 6, 2022

Changes

Add the missing close-issue-reason option to the action.yml

Context

It's great that #764 has added the close-issue-reason option to allow closing a stale issue with a specified reason. But it seems this new option is missing in the action.yml configuration file, so a warning will be generated when running the action and the stale issues can't be closed with the expected reason.

image

Please refer to the following action for more details: https://github.com/apache/echarts/actions/runs/2618863511


Oh... I'm sorry I just found the feature hasn't been released. Perhaps, can we publish a new version for it?

@plainheart plainheart requested a review from a team as a code owner July 6, 2022 06:38
@isaak654
Copy link

@luketomlinson

@luketomlinson luketomlinson merged commit aaab997 into actions:main Jul 11, 2022
5 checks passed
@jtbandes
Copy link
Contributor

Thanks, I missed this in #764!

@jtbandes
Copy link
Contributor

@luketomlinson would you be able to tag/publish a new version soon?

@plainheart plainheart deleted the fix-option/close-issue-reason branch July 11, 2022 23:36
@plainheart
Copy link
Contributor Author

Hi @luketomlinson, I'd like to know if we can publish a new version for the close-issue-reason feature. We are waiting for it. Thanks! :)

@luketomlinson
Copy link
Collaborator

@jtbandes @plainheart Done: https://github.com/actions/stale/releases/tag/v5.1.0

@luketomlinson
Copy link
Collaborator

Just a heads up, the release caused an issue: #774, so I reverted for now. You can point your workflows to @v5.1.0 in the meantime (though no guarantees you won't hit the bug)

@luketomlinson
Copy link
Collaborator

I've opened #775 to fix the issue. I'll try to get this in next week and ship a new version.

@luketomlinson
Copy link
Collaborator

New version is shipped, please let me know if you see any more issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants