/ stale Public
Fix issue when days-before-close is more than days-before-stale #775
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
When we introduced #717, we inadvertently introduced a bug that would occur when
Every issue should be
stalein this scenario and the
stalelabel would be applied as expected. The problem was is that the action would look back
30days and ALWAYS see an update and immediately remove the stale label.
My changes change the logic that can potentially "un-stale" an issue. Rather than check for an update in the last
days-before-closedays (e.g. 30), I check if the update occurred AFTER the stale date. This is subtle, but caused big issues for actions when