Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix-795] Fix date comparison edge case #816

Merged
merged 5 commits into from Sep 12, 2022
Merged

[Bugfix-795] Fix date comparison edge case #816

merged 5 commits into from Sep 12, 2022

Conversation

luketomlinson
Copy link
Collaborator

Changes

  • Fixes an issue where the issue.updatedAt and markedStaleOn dates can be off by a second. This is done by first checking the date for equality (within 15 second tolerance) and then checking if issue.updatedAt comes after the markedStaleOn date.

Context

fixes #795

@luketomlinson luketomlinson requested a review from a team as a code owner Sep 9, 2022
@luketomlinson luketomlinson changed the title Bugfix/795 [Bugfix-795] Fix date comparison edge case Sep 9, 2022
@luketomlinson luketomlinson merged commit 8e8a0e6 into main Sep 12, 2022
5 checks passed
@luketomlinson luketomlinson deleted the bugfix/795 branch Sep 12, 2022
JoannaaKL pushed a commit that referenced this pull request Sep 12, 2022
* Fix updatedAt and markedStaleOn date comparison

* Delete accidental file

* Refactor

* Cleanup

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems since moving to v5 - action takes bot comment as a regular update
2 participants