-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add D workflow #546
Add D workflow #546
Conversation
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: dlang-community/setup-dlang@7c3e57bdc1ff2d8994f00e61b3ef400e67d2d7ac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we use master directly if this is the template for users and they have to trust setup-dlang either way? (and if they are really worried they can always lock the version).
The way I see it this might hurt the standard user as he won't be able to receive any bugfix to the build pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately that's the way the guidelines want it to be: https://github.com/actions/starter-workflows/blob/0170fa5239991d2141e572a1b334ea577ea4f060/.github/pull_request_template.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Rebased on master. Ping @ethomson @andymckay . |
|
Rebased on master. @jclem : Any chance you could review this ? |
12f5b04
to
d61059b
Compare
|
Rebased / retargeted. Is anything else missing ? |
|
ฉันไม่รู้
ในวันที่ พ. 29 ก.ค. 2020 10:12 Mathias LANG <notifications@github.com>
เขียนว่า:
… Rebased / retargeted. Is anything else missing ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#546 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APEUXW2MFBBTJFU33H6WOGDR56HQTANCNFSM4N3LORWQ>
.
|
D is a statically and strongly typed, multi-paradigm, general-purpose native programming language. D is fully open-source and maintained by a volunteer community. For more information, see https://dlang.org This patch adds a minimal workflow that allows users to compile D projects that use DUB, the official D package manager and build tool. The workflow uses the community-maintained `setup-dlang` action, which can install any version of `dmd` (the reference compiler), or `ldc` (the LLVM-based, performance oriented compiler, on any of the three platforms currently supported by Github free runners. Support for GDC is not yet implemented. The logo used (d.svg) originates from https://github.com/dlang/dlang.org/blob/master/images/dlogo_2015.svg and is available under the BSL-1.0 license (https://github.com/dlang/dlang.org/blob/master/LICENSE.txt) Co-Authored-By: Mathias Lang <pro.mathias.lang@gmail.com>
|
Rebased on |
|
So sorry for the delay @Geod24. I think this is good to merge. |
|
@andymckay : Thanks! |
|
@andymckay : Any update on the guidelines regarding versions ? This uses the hash, as prescribed by this repository's documentation, but most other places do not. I've listed a few examples here. |
|
@Geod24 most of those are referencing actions from partners and have different guidelines. I think one or two did slip through the net and we should review those to match the new guidelines. Thank you for the heads up on that. |
Description (and commit message):
I believe this satisfies all the requirements set forth by the contributing guidelines.
It does use an external action, which was the blocker in the previous attempt (#74), but according to the current guidelines this is tolerated if the disclaimer message is present (which I added).
I also used the hash, as requested in the guideline, despite it being very user-unfriendly. The release used is here:
https://github.com/dlang-community/setup-dlang/releases/tag/v1.0.0
Official website: https://dlang.org/
Official Github organization: https://github.com/orgs/dlang
Action being used: https://github.com/dlang-community/setup-dlang
You can see that the action is in a different organization, however that is simply to simplify access management. As you can see I am a member of both organizations.
As a side note:
ubuntu-latest, like almost everyone else;