Add DLang workflow #74

ErnyTech · 2019-08-27T22:26:56Z

Add DLang workflow

D is a general-purpose programming language,
for more information: dlang.org

This patch adds a minimal workflow that allows
you to compile D projects that use DUB (the D package registry).

I used the D Compiler Installation
(https://github.com/marketplace/actions/d-compiler-installation) for setup the compiler for D.

The logo used (dlang.svg) was taken from here
https://github.com/dlang/dlang.org/blob/master/images/dlogo_2015.svg
and is available under the BSL-1.0 license (https://github.com/dlang/dlang.org/blob/master/LICENSE.txt)

ci/dlang.yml

andre2007 · 2019-09-08T12:23:33Z

@ErnyTech I justed checked the times. Using the container functionality in github actions seems to be rather slow ~44 seconds just for setting up the container. Also on the second try it doesn't get faster.
For comparison, by using the install.sh script instead, the runtime of the whole job is ~15 seconds.

We could leave it in this pull request but in the long run we should find something more performant.
(Also installing dmd.deb package is as slow as using the container https://github.com/CodeMyst/ghactions-test/blob/master/.github/workflows/blank.yml)

andre2007 · 2019-09-18T19:38:10Z

@ErnyTech

Could you change the workflow to this one?
It is several times faster than the container solution.

name: DLang

on: [push]

jobs:
  build:

    runs-on: ubuntu-latest
    
    steps:
    - uses: actions/checkout@v1
    - uses: mihails-strasuns/setup-dlang@v0
    - name: Build
      run: dub build
    - name: Run tests
      run: dub test

ErnyTech · 2019-09-18T19:39:16Z

Yes absolutely, I will do it by tomorrow

D is a general-purpose programming language, for more information: dlang.org This patch adds a minimal workflow that allows you to compile D projects that use DUB (the D package registry). I used the D Compiler Installation (https://github.com/marketplace/actions/d-compiler-installation) for setup the compiler for D. The logo used (dlang.svg) was taken from here https://github.com/dlang/dlang.org/blob/master/images/dlogo_2015.svg and is available under the BSL-1.0 license (https://github.com/dlang/dlang.org/blob/master/LICENSE.txt) Signed-off-by: Ernesto Castellotti <erny.castell@gmail.com>

ErnyTech · 2019-09-19T14:45:30Z

@andre2007 done!

andre2007 · 2019-09-19T15:53:46Z

@ErnyTech Fantastic, thanks a lot

andre2007 · 2019-09-23T11:00:08Z

Hi @mscoutermarsh, Hi @jeremyepling
could you give feedback on this pull request. Is anything missing?

Kind regards
André

andymckay · 2019-10-01T23:54:42Z

👋 Sorry everyone for the delay on this. At this point we are working on adding some guidelines for this repository in this PR #156. One thing I note is that this uses an Action outside of the actions org and our first pass of guidelines suggests that we wouldn't allow that.

Your next question then is probably "how can we get dlang added to the actions" and I'm not sure on the answer to that right now.

So sorry, there might be some work to figure out what to do with this workflow. Thank you 🙇 for your contribution and we'll try and get there.

Geod24

Some wording requirements and documentation fixes. Unfortunately this is still blocker on the fate of the Github action being used.

Geod24 · 2020-04-16T05:18:13Z

ci/dlang.yml

@@ -0,0 +1,16 @@
+name: DLang
+
+on: [push]


Suggested change

on: [push]

on:

push:

branches: [ master ]

pull_request:

branches: [ master ]

d037e97

Geod24 · 2020-04-16T05:21:50Z

ci/dlang.yml

+jobs:
+  build:
+
+    runs-on: ubuntu-latest


Looks like other actions are doing this too. However nothing in this action prevents it to be run on all three platforms at the moment.

Geod24 · 2020-04-16T05:21:58Z

ci/dlang.yml

+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v1


Suggested change

- uses: actions/checkout@v1

- uses: actions/checkout@v2

Geod24 · 2020-04-16T05:22:30Z

ci/dlang.yml

+
+    steps:
+    - uses: actions/checkout@v1
+    - uses: mihails-strasuns/setup-dlang@v0.2.0


Suggested change

- uses: mihails-strasuns/setup-dlang@v0.2.0

- uses: mihails-strasuns/setup-dlang@v0.5.0

Geod24 · 2020-04-16T07:29:59Z

ci/dlang.yml

+    - name: Build
+      run: dub build
+    - name: Run tests
+      run: dub test


Suggested change

- name: Build

run: dub build

- name: Run tests

run: dub test

- name: Build & Test

run: |

# Build the project, with its main file included, without unittests

dub build --compiler=$DC

# Build and run tests, as defined by `unittest` configuration

# In this mode, `mainSourceFile` is excluded and `version (unittest)` are included

# See https://dub.pm/package-format-json.html#configurations

dub test --compiler=$DC

We might also want to publish artifacts, but that's a bit more involved.

Geod24 · 2020-04-16T07:33:09Z

ci/properties/dlang.properties.json

@@ -0,0 +1,6 @@
+{
+    "name": "D Programming Language",


Suggested change

"name": "D Programming Language",

"name": "D",

Geod24 · 2020-04-16T07:34:34Z

ci/properties/dlang.properties.json

@@ -0,0 +1,6 @@
+{
+    "name": "D Programming Language",
+    "description": "Build, run and test a D Programming Language project with Dub.",


Suggested change

"description": "Build, run and test a D Programming Language project with Dub.",

"description": "Build, run and test a D project with Dub.",

Geod24 · 2020-04-16T07:34:44Z

ci/properties/dlang.properties.json

+    "name": "D Programming Language",
+    "description": "Build, run and test a D Programming Language project with Dub.",
+    "iconName": "dlang",
+    "categories": ["D Programming Language"]


Suggested change

"categories": ["D Programming Language"]

"categories": [ "D" ]

I looked up other languages and none is using "Programming Language" or "lang" suffix

Geod24 · 2020-06-11T08:16:51Z

@andymckay : Is there anything our community can do to help us make progress on this ?

I've personally been using the action referenced here for many months to great success.
It was recently tagged as v1, and transferred to a more official location, dlang-community/setup-dlang . There is an issue open by @ethomson (dlang-community/setup-dlang#13) for Github to take ownership on it, but it has been stalled for a few months.

I understand those are difficult times and you are probably extremely busy, so we'd really like to make this as simple as possible. Looking at other actions in this repository, there are plenty of places where external actions, images, or scripts are used:

starter-workflows/ci/ibm.yml

Line 39 in 0170fa5

curl -fsSL https://clis.cloud.ibm.com/install/linux | sh
starter-workflows/ci/aws.yml

Line 42 in 0170fa5

uses: aws-actions/configure-aws-credentials@v1
starter-workflows/ci/aws.yml

Line 75 in 0170fa5

uses: aws-actions/amazon-ecs-deploy-task-definition@v1
starter-workflows/ci/azure.yml

Line 42 in 0170fa5

uses: azure/webapps-deploy@v2
starter-workflows/ci/crystal.yml

Line 15 in 0170fa5

image: crystallang/crystal
starter-workflows/ci/dart.yml

Line 15 in 0170fa5

image: google/dart:latest
starter-workflows/ci/dotnet-core-desktop.yml

Line 78 in 0170fa5

uses: microsoft/setup-msbuild@2008f912f56e61277eefaac6d1888b750582aa16
starter-workflows/ci/erlang.yml

Line 16 in 0170fa5

image: erlang:22.0.7
starter-workflows/ci/go.yml

Line 29 in 0170fa5

curl https://raw.githubusercontent.com/golang/dep/master/install.sh | sh
starter-workflows/ci/google.yml

Line 38 in 0170fa5

- uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
starter-workflows/ci/google.yml

Line 65 in 0170fa5

curl -o kustomize --location https://github.com/kubernetes-sigs/kustomize/releases/download/v3.1.0/kustomize_3.1.0_linux_amd64
starter-workflows/ci/tencent.yml

Line 58 in 0170fa5

uses: TencentCloud/tke-cluster-credential-action@v1
starter-workflows/ci/terraform.yml

Line 70 in 0170fa5

uses: hashicorp/setup-terraform@v1

I also listed scripts here, because curling a script and piping it to bash is no different than running an arbitrary action, security wise. If that is somehow preferred to an action, we also have a script to do that, which works on all 3 platforms (https://dlang.org/install.sh).

It would be greatly appreciated if, given the new, official location of the action, you could agree to move forward on this. In which case, I can raise a new PR with the review I left on April 16th fixed, unless @ErnyTech gets to it first.

Geod24 · 2020-06-11T12:17:21Z

After reviewing the contributions guidelines, it turns out this issue has been addressed, and third-party official actions are accepted as long as they satisfy certain criteria (have a disclaimer and use the hash). So I submitted #546, which also contain my feedback here (and is up to the new standards).

andymckay · 2020-08-21T00:29:39Z

We merged #546 so I think we can close this one now. Sorry @ErnyTech it took us so long to get around to merging a D workflow, but thank you for your contribution 🙇🏾

wilzbach reviewed Sep 7, 2019

View reviewed changes

ci/dlang.yml Outdated Show resolved Hide resolved

ci/dlang.yml Show resolved Hide resolved

andre2007 mentioned this pull request Sep 12, 2019

D starter workflow based on setup-dlang dlang-community/setup-dlang#1

Closed

ErnyTech force-pushed the master branch from 210480b to 6b0722f Compare September 19, 2019 14:44

andre2007 approved these changes Sep 19, 2019

View reviewed changes

ihch mentioned this pull request Oct 9, 2019

Create github actions workflow ihch/dish#5

Merged

ethomson mentioned this pull request Nov 3, 2019

Can GitHub Actions take a fork of this repository? dlang-community/setup-dlang#13

Open

Geod24 reviewed Apr 16, 2020

View reviewed changes

Geod24 mentioned this pull request Jun 11, 2020

Add D workflow #546

Merged

andymckay closed this Aug 21, 2020

andymckay mentioned this pull request Aug 21, 2020

Pause on accepting on new community starter workflows #631

Closed

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DLang workflow #74

Add DLang workflow #74

ErnyTech commented Aug 27, 2019 •

edited

Loading

andre2007 commented Sep 8, 2019 •

edited

Loading

andre2007 commented Sep 18, 2019

ErnyTech commented Sep 18, 2019

ErnyTech commented Sep 19, 2019

andre2007 commented Sep 19, 2019

andre2007 commented Sep 23, 2019

andymckay commented Oct 1, 2019 •

edited

Loading

Geod24 left a comment

Geod24 Apr 16, 2020

Geod24 Apr 16, 2020

Geod24 Apr 16, 2020

Geod24 Apr 16, 2020

Geod24 Apr 16, 2020

Geod24 Apr 16, 2020

Geod24 Apr 16, 2020

Geod24 Apr 16, 2020

Geod24 commented Jun 11, 2020

Geod24 commented Jun 11, 2020

andymckay commented Aug 21, 2020

-on: [push]
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]

	- uses: mihails-strasuns/setup-dlang@v0.2.0
	- uses: mihails-strasuns/setup-dlang@v0.5.0

-    - name: Build
-      run: dub build
-    - name: Run tests
-      run: dub test
+    - name: Build & Test
+      run: |
+        # Build the project, with its main file included, without unittests
+        dub build --compiler=$DC
+        # Build and run tests, as defined by `unittest` configuration
+        # In this mode, `mainSourceFile` is excluded and `version (unittest)` are included
+        # See https://dub.pm/package-format-json.html#configurations
+        dub test --compiler=$DC

	"description": "Build, run and test a D Programming Language project with Dub.",
	"description": "Build, run and test a D project with Dub.",

	"categories": ["D Programming Language"]
	"categories": [ "D" ]

Add DLang workflow #74

Add DLang workflow #74

Conversation

ErnyTech commented Aug 27, 2019 • edited Loading

andre2007 commented Sep 8, 2019 • edited Loading

andre2007 commented Sep 18, 2019

ErnyTech commented Sep 18, 2019

ErnyTech commented Sep 19, 2019

andre2007 commented Sep 19, 2019

andre2007 commented Sep 23, 2019

andymckay commented Oct 1, 2019 • edited Loading

Geod24 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Geod24 commented Jun 11, 2020

Geod24 commented Jun 11, 2020

andymckay commented Aug 21, 2020

ErnyTech commented Aug 27, 2019 •

edited

Loading

andre2007 commented Sep 8, 2019 •

edited

Loading

andymckay commented Oct 1, 2019 •

edited

Loading