Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unchanged files with check annotations" is disruptive and should be configurable #457

Open
ThiefMaster opened this issue May 14, 2020 · 5 comments
Labels
enhancement New feature or request external

Comments

@ThiefMaster
Copy link

The "Unchanged files with check annotations" feature when using problem matchers needs to be configurable (for each action/matcher): It's pretty discouraging for a new contributor to see loads of unrelated warnings from a style checker in their first PR that are completely unrelated, not to mention that it also adds noise for checkers where you know that it's not something that could be caused in changes from another file in the PR.

For example, I'm running stylelint with no-descending-specificity warnings enabled. For CSS added in a PR those warnings may be useful, but I REALLY don't care about the almost 1000 warnings in our existing codebase (some even in legacy files) when running CI for a new PR!

Right now the only workaround for this is to either disable the rule altogether, only show errors but not warnings, or somehow only run the linter on new/changed files when running the action for a PR.

@majew7
Copy link

majew7 commented Jun 9, 2023

only show errors but not warnings

Yes, in the context of .NET, I worked around this "Unchanged files with check annotations" beta feature by building my solution without warnings.

dotnet build MySolution.sln --no-restore /property:WarningLevel=0

Very lame.

@dpwiz
Copy link

dpwiz commented Sep 18, 2023

I only recently got to using GitHub full time and this s..t makes my blood boil 🤬
It is makred beta, you'd betta have a way to remove it 💢

@mistercrunch
Copy link

Please allow us to turn this off! For us, warnings are useful in the context of eslint and certain workflows, but not useful in the context of an unrelated PR. There should always be an easy way to turn off beta features like this one.

@kberg
Copy link

kberg commented Apr 1, 2024

This is preventing me from merging perfectly good PRs, and is incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external
Projects
None yet
Development

No branches or pull requests

6 participants