Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add helpers for working with paths across OSes #1102

Merged
merged 1 commit into from Jun 15, 2022
Merged

core: add helpers for working with paths across OSes #1102

merged 1 commit into from Jun 15, 2022

Conversation

sethvargo
Copy link
Contributor

@sethvargo sethvargo commented May 26, 2022

No description provided.

@sethvargo sethvargo requested a review from a team as a code owner May 26, 2022
@sethvargo
Copy link
Contributor Author

sethvargo commented May 26, 2022

/cc @jmillsy @konradpabjan @thboop

Copy link
Contributor

@konradpabjan konradpabjan left a comment

Overall this looks great!

Could you go ahead and document these new functions in the README for @actions/core: https://github.com/actions/toolkit/tree/main/packages/core

@sethvargo
Copy link
Contributor Author

sethvargo commented May 26, 2022

@konradpabjan done

Copy link
Contributor

@konradpabjan konradpabjan left a comment

Looks good to me!

I'll differ for the final approval from @thboop before merging in

thboop
thboop approved these changes Jun 15, 2022
Copy link
Collaborator

@thboop thboop left a comment

LGTM thanks for the contribution!

@thboop thboop merged commit 00282d6 into actions:main Jun 15, 2022
12 checks passed
@sethvargo sethvargo deleted the sethvargo/path branch Jun 15, 2022
@RA80533
Copy link

RA80533 commented Jun 20, 2022

I was wondering what the purpose of these functions was compared to those from the native Path module (link). I figured it was discussed offline since it wasn't in the PR description.

I'd love to understand so I can have a better idea of when they're recommended. Thanks!

@sethvargo
Copy link
Contributor Author

sethvargo commented Jun 20, 2022

Hi @RA80533 these functions are for converting from platform-specific or non-platform-specific paths, regardless of the underlying operating system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants