-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing archiver
package with direct use of zip-stream
for fixing macOS upload issues
#1690
Open
vmjoseph
wants to merge
75
commits into
main
Choose a base branch
from
vmjoseph/node-js-monitor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+513
−145
Open
Changes from 74 commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
1f22f9f
adding debug for mac upload testing
vmjoseph 4617da2
audit fix
vmjoseph 4090623
update debug statement
vmjoseph 13d981a
Adding buffer and zlib options
vmjoseph e71ddb9
updating append and directory zips
vmjoseph 14eee6f
updating event handlers
vmjoseph 6e4aebb
cleaning up unused imports
vmjoseph 6defe19
replacing constructor for zipstream
vmjoseph fda9d58
replacing constructor for zipstream with default
vmjoseph 560ae4d
updating archive import
vmjoseph 8e29fb2
adding default back to zipstream call
vmjoseph 97629b8
adding archiver back for download
vmjoseph ca87c5e
testing debug statements
vmjoseph 7441cc7
Removing pipe
vmjoseph 06482c6
adding promise to upload
vmjoseph d97edf7
cleaning up warning callack
vmjoseph 088b976
cleaning up callback methods
vmjoseph 9299663
adding promise all
vmjoseph b1f55c6
adding finalize
vmjoseph 1875173
update loop for upload
vmjoseph bef1fc5
adding check for running
vmjoseph fd88cbe
adding check for running
vmjoseph 66343fa
add resolve all promises again
vmjoseph c7de68f
updating resolves
vmjoseph fe0c0de
adding lock
vmjoseph 97e4fcf
wait on write stream
vmjoseph f33a3f4
Remove finalize
vmjoseph 180b75b
wrap promises in chain
vmjoseph 077846e
adding readable check
vmjoseph 73f526b
adding closed check
vmjoseph 26b62e0
adding more logging
vmjoseph e4c0440
adding more logging
vmjoseph a768aa3
adding more logging
vmjoseph d597cf2
adding upload stream check
vmjoseph 6ac9cbf
check if upload and zipload streams are writable
vmjoseph d2d6999
adding write check
vmjoseph 31a6086
Adding concurrency and upload response logs
vmjoseph c9e825e
add blob client property check
vmjoseph 0a0e70d
Add another catch to see if upload stream is failing
vmjoseph 5959333
defaulting compression level
vmjoseph 17c4cab
adding constant zlib compression level
vmjoseph b6c87ce
Adding more error handlrs
vmjoseph 9322468
Adding pipe back
vmjoseph bc893bf
adding compression level back
vmjoseph 5288db3
removing debugging statements
vmjoseph 0f23ae1
re-adding old async/await pattern
vmjoseph d02a834
Remove other debug statements
vmjoseph 6d94ad1
Removing uneeded libs
vmjoseph a2852ce
adding catch to upload zip
vmjoseph c14e304
adding more debugging statements
vmjoseph 90ee020
cleaning up debug statements
vmjoseph 2da5288
cleanup
vmjoseph 2d06555
Merge branch 'main' into vmjoseph/node-js-monitor
vmjoseph 2f2738e
removing old packages
vmjoseph 4c878a6
adding back archiver
vmjoseph dea3595
re-adding archiver for download
vmjoseph 2c4f0f5
adding error checks
vmjoseph 6eff4e9
adding more debug statements
vmjoseph 4778aeb
adding asnyc handler back
vmjoseph 23039a4
adding asnyc handler back
vmjoseph a8fa53b
test async eachof
vmjoseph a2a8a72
test queue
vmjoseph a926fff
adding queue back
vmjoseph 84d3cef
Removing extra logs
vmjoseph 96ef8d5
adding more error handling
vmjoseph c5f3463
adding more descriptive error
vmjoseph 38f54e9
Adding debug statement for upload
vmjoseph ce60352
adding asysnc zip entry logic handling
vmjoseph e7f4586
Merge branch 'main' into vmjoseph/node-js-monitor
vmjoseph 4f54b86
updating errors
vmjoseph 67c3837
updating errors
vmjoseph 6e1d754
updating tests
vmjoseph da5e926
removing promise wrap
vmjoseph bcaba45
reverting http update
vmjoseph 42b0077
resolve merge conflicts
jtamsut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,4 +33,4 @@ | |
"ts-jest": "^29.1.1", | ||
"typescript": "^5.2.2" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be uncommented?