Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice annotation and support more annotation fields #855

Merged
merged 9 commits into from Jul 28, 2021

Conversation

luketomlinson
Copy link
Collaborator

@luketomlinson luketomlinson commented Jun 29, 2021

This PR adds support for:

  • The notice annotation level.
  • The title, line, endLine, col, and endColumn fields.

Depends on these runner changes.

@luketomlinson luketomlinson requested a review from as a code owner Jun 29, 2021
packages/core/src/core.ts Outdated Show resolved Hide resolved
packages/core/src/utils.ts Outdated Show resolved Hide resolved
packages/core/src/utils.ts Outdated Show resolved Hide resolved
thboop
thboop approved these changes Jul 13, 2021
Copy link
Collaborator

@thboop thboop left a comment

LGTM

packages/core/src/utils.ts Outdated Show resolved Hide resolved
@luketomlinson luketomlinson merged commit f0b00fd into main Jul 28, 2021
12 checks passed
@luketomlinson luketomlinson deleted the annotations-updates branch Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants