Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file property to AnnotationProperties #896

Merged
merged 1 commit into from Sep 28, 2021
Merged

Add file property to AnnotationProperties #896

merged 1 commit into from Sep 28, 2021

Conversation

Marcono1234
Copy link
Contributor

Fixes #892
Also adds missing tests for core.notice.

Feedback is appreciated, especially whether this fulfills the pull request requirements. In case you already had an internal pull request for #892, or were working locally on it, feel free to reject this pull request.

@Marcono1234 Marcono1234 requested a review from a team as a code owner August 30, 2021 19:45
@im-mortal
Copy link

Also counts towards closing #186. Waiting for this merge!

Copy link
Collaborator

@luketomlinson luketomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @Marcono1234. Thanks for the PR! :shipit:

@BeeeQueue
Copy link

Could this PR be merged as well? 😄

@luketomlinson luketomlinson merged commit 60145e4 into actions:main Sep 28, 2021
11 of 12 checks passed
@Marcono1234 Marcono1234 deleted the marcono1234/AnnotationProperties-file branch September 28, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add file parameter to AnnotationProperties
4 participants