Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lockfileVersion in package-lock.json #302

Merged
merged 16 commits into from Mar 3, 2022

Conversation

jtamsut
Copy link
Contributor

@jtamsut jtamsut commented Mar 1, 2022

This change addresses this issue.

Documentation for the semantics of lockfileVersion can be found here.

lockfileVersion: 2 is used for npm v7 (but is also backwards compatible with npm v5 and v6).

@jtamsut jtamsut requested a review from konradpabjan Mar 1, 2022
@jtamsut jtamsut requested a review from a team as a code owner Mar 1, 2022
@jtamsut jtamsut marked this pull request as draft Mar 1, 2022
@jtamsut jtamsut marked this pull request as ready for review Mar 1, 2022
@konradpabjan
Copy link
Collaborator

konradpabjan commented Mar 3, 2022

Looking good, don't forget the changes in the Readme for going from v2->v3

Copy link
Member

@robherley robherley left a comment

We should also change @actions/checkout to v3 since it was released a couple days ago: https://github.com/actions/checkout/releases/tag/v3.0.0

- uses: actions/checkout@v2

@@ -1,6 +1,6 @@
---
name: "@actions/artifact"
version: 0.6.1
version: 1.0.0
Copy link
Member

@robherley robherley Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why the bump from 0.6.1 to 1.0.0 here?

Copy link
Contributor Author

@jtamsut jtamsut Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So rationale here was that versions < 1.0.0 are "pre-release" versions. Since @actions/artifact is released and used in production we wanted to give it a v1 version number. v1.0.0 is backwards compatible with previous versions.

Copy link
Contributor Author

@jtamsut jtamsut Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch with @actions/checkout@v3 😄 ! Didn't know that existed. I think upgrading checkout to use checkout@v3 should be done in a separate PR.

@jtamsut jtamsut requested a review from robherley Mar 3, 2022
@jtamsut jtamsut merged commit 6673cd0 into main Mar 3, 2022
8 checks passed
Copy link

@soloinovator soloinovator left a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants