Update lockfileVersion in package-lock.json
#302
Conversation
|
Looking good, don't forget the changes in the Readme for going from v2->v3 |
There was a problem hiding this comment.
We should also change @actions/checkout to v3 since it was released a couple days ago: https://github.com/actions/checkout/releases/tag/v3.0.0
Line 31 in ecad7d0
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| name: "@actions/artifact" | |||
| version: 0.6.1 | |||
| version: 1.0.0 | |||
There was a problem hiding this comment.
Just curious, why the bump from 0.6.1 to 1.0.0 here?
There was a problem hiding this comment.
So rationale here was that versions < 1.0.0 are "pre-release" versions. Since @actions/artifact is released and used in production we wanted to give it a v1 version number. v1.0.0 is backwards compatible with previous versions.
There was a problem hiding this comment.
Good catch with @actions/checkout@v3 😄 ! Didn't know that existed. I think upgrading checkout to use checkout@v3 should be done in a separate PR.
This change addresses this issue.
Documentation for the semantics of
lockfileVersioncan be found here.lockfileVersion: 2is used for npmv7(but is also backwards compatible with npmv5andv6).