Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create devcontainer for codespaces + update all dev dependencies #375

merged 29 commits into from Jan 5, 2023


Copy link

@konradpabjan konradpabjan commented Jan 4, 2023

Right now if you create a codespace is creates one with a really old node version and npm and that causes package.json to drop down to version 1 and it messes up a bunch of things.

I'm adding a basic devcontainer so that we have a basic node codespace that gets created. This makes it easier to to development and for small changes such as package updates.

In order to make node16 work in CI, we had to update all dev dependencies as well. This fixed something with NPM due to really old deprecated packages 🤷‍♂️

We also moved from zeit/ncc to vercel/ncc which is supported and our other first party actions use this. Because of this we had to rebuild index.js substantially

@konradpabjan konradpabjan requested a review from a team as a code owner January 4, 2023 19:29
@konradpabjan konradpabjan marked this pull request as draft January 4, 2023 20:49
@konradpabjan konradpabjan changed the title Create devcontainer for codespaces Create devcontainer for codespaces + update all dev dependencies Jan 5, 2023
@konradpabjan konradpabjan marked this pull request as ready for review January 5, 2023 20:17
@konradpabjan konradpabjan merged commit 013d2b8 into main Jan 5, 2023
8 checks passed
@konradpabjan konradpabjan deleted the konradpabjan/codespace-devcontainer branch January 5, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants