Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/Add protobuf #51

Closed
2 of 5 tasks
jmhodges opened this issue Oct 20, 2019 · 5 comments
Closed
2 of 5 tasks

Update/Add protobuf #51

jmhodges opened this issue Oct 20, 2019 · 5 comments
Labels
Area: C/C++ wontfix

Comments

@jmhodges
Copy link

@jmhodges jmhodges commented Oct 20, 2019

Tool information

  • Tool name: protobuf
  • Add or update? Add
  • Desired version: v3.10.0
  • Approximate size:
  • If this is an add request:

Virtual environments affected

  • macOS 10.14
  • Ubuntu 16.04 LTS
  • Ubuntu 18.04 LTS
  • Windows Server 2016 R2
  • Windows Server 2019

Can this tool be installed during the build?
Yep. But takes well over 15 minutes to build all of the languages it supports.

I've got one GH Action attempt working now, but the 15 minute time line is too long and I'm going to try if building fewer language supports makes it faster. It's a lot of C++. And, unfortunately, ubuntu-latest only supports protobuf 3.0.

Are you willing to submit a PR?
Sure, but I don't see any directions on where and how to do that?

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 21, 2020

This issue has not had any activity for 45 days and will be closed in 45 days if there continues to be no activity.

@jmhodges
Copy link
Author

@jmhodges jmhodges commented Feb 21, 2020

Ping!

@maxim-lobanov
Copy link
Contributor

@maxim-lobanov maxim-lobanov commented Mar 17, 2020

@jmhodges , thank you for sharing feature request.

Have you tried to use actions/cache to build it once and then cache? I believe it will significantly reduce the time of your build

@alepauly
Copy link
Contributor

@alepauly alepauly commented Apr 6, 2020

@jmhodges well it took me a while to get here, apologies for the delay in responding. We can't add protobuf to the environments at this time considering that it's fairly specialized and it we are unsure of maintenance going forward. Hopefully the actions/cache as suggested by @maxim-lobanov can improve the timing.

@alepauly alepauly closed this as completed Apr 6, 2020
@alepauly alepauly added wontfix and removed needs eyes labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: C/C++ wontfix
Projects
None yet
Development

No branches or pull requests

3 participants