Skip to content

Loading…

Dropdown menu in navigation menu isn't working #1986

Closed
macfanatic opened this Issue · 3 comments

2 participants

@macfanatic

Just did a simple smoke screen test of the dummy app with:

ActiveAdmin.register Post do
  menu parent: "Users"
end

The item doesn't show up in the menu at all. The test suite passes with flying colors, so need to add a failing test as part of this as well. Definitely introduced as part of #1967 however.

@macfanatic macfanatic was assigned
@seanlinsley
Active Admin member

I need to rebase my PR (#1488) anyway, so I'll likely be investigating this as well.

@macfanatic

I've written some specs & a feature that fails finally, so just trying to get the fix in place & then I'll convert this to a PR.

@macfanatic macfanatic referenced this issue
Commit has since been removed from the repository and is no longer available.
@macfanatic macfanatic referenced this issue
Commit has since been removed from the repository and is no longer available.
@macfanatic

Above pull request resolves this issue.

@macfanatic macfanatic closed this
@macfanatic macfanatic referenced this issue
Commit has since been removed from the repository and is no longer available.
@macfanatic macfanatic added a commit to macfanatic/active_admin that referenced this issue
@macfanatic macfanatic Fixes #1986 - Menu should register child regardless of AA resource lo…
…ad order

* ActiveAdmin::MenuItem#dom_id removed, wasn't needed
* Load order is no longer important in registering menu items
7b80902
@macfanatic macfanatic removed their assignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.