Exclude devise :timedout from flash messages #1048

Merged
merged 1 commit into from Nov 8, 2012

Conversation

Projects
None yet
2 participants
Contributor

latortuga commented Feb 19, 2012

This is the change to exclude the devise :timedout key from showing up in the flash messages (Issue #1005). I don't have a spec for this because I'm not quite sure how to add one for this functionality but this is my proposed fix.

Note that this is a Rails-specific fix because it relies on ActiveSupport's addition of Hash#except

Contributor

gregbell commented Feb 21, 2012

Thanks Drew!

There is another layout that is rendered for the logged out views which needs to be updated also https://github.com/gregbell/active_admin/blob/master/app/views/layouts/active_admin_logged_out.html.erb

The logged out views should really be rendered the same way as the logged in ones. For now though, we can just update it in the second spot.

gregbell was assigned Feb 22, 2012

gregbell merged commit 4497559 into activeadmin:master Nov 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment