Don't let wrapping tabs break the design (fix #713)

[teddyzetterlund]

The quickest and easiest fix for the wrapping tabs problem (#713).

A more robust solution would better but maybe that's something to look for in more responsive design.

If overflow: hidden; is not a viable option then I'd suggest we just the micro clearfix instead:

#header {
  &:after {
    clear: both;
    content: "";
    display: table;
  }
}

[travisbot]

This pull request passes (merged 435acb2 into 65c1e4e).

[pcreux]

All right, could you align the user infos?

That's great!

That's ok...

[teddyzetterlund]

I wonder why I didn't see that. I'll fix it.

Teddy Zetterlund
Web Developer

http://twitter.com/teddyzetterlund

On Wednesday 4 July 2012 at 17:42, Philippe Creux wrote:

All right, could you align the user infos?

That's great!

That's ok...

---

Reply to this email directly or view it on GitHub:
#1457 (comment)

[acurley]

I don' think that overflow: hidden works well because it ruins the display of dropdown lists (i.e. doesn't display the dropdown <ul> ).

[teddyzetterlund]

Ah, didn't about those when I initiated this pull request. I'll change it to use a clearfix instead.

I'll continue work on this PR next week.

[pcreux]

Sweet! :)

[travisbot]

This pull request passes (merged 326aea0 into 65c1e4e).

[dustMason]

hey dudes, any reason this never got merged in? would be nice to have!

[teddyzetterlund]

Overflow still needs to be replaced with a clearfix-solution, other than that I'm not sure. I'll have a look at it sometime this week.

[seanlinsley]

@teddyzetterlund still up for working on this PR?

I know @gregbell is working on the Twitter Bootstrap conversion, but until that comes out it would be nice to have sane tab overflow.

[teddyzetterlund]

@daxter I seem to have messed up this particular pull request by removing my repository of active_admin some time ago, but if @gregbell shows any sign of wanting to merge it I don't mind creating a new pull request with the fixes in it.

[maax]

Hey! I fixed this problem for a project of ours and just made a PR: #2046.

[teddyzetterlund]

@maax Good initiative. Not the way I would've solved it, but as long as IE7 is not supposed to be supported it's as good as what I had in mind. I'll close this pull request.