Display a sentence describing the current scope & filters on Index page. #1532

Closed
wants to merge 11 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

pcreux commented Jul 18, 2012

It looks like this:

screenshot

That's really useful when you start to mix Scopes and Filters.

This pull request fails (merged cf1a5c9 into e2e5384).

This pull request fails (merged 98321ba into e2e5384).

Contributor

pcreux commented Sep 26, 2012

Errors:

it { should == 'All Posts with Author "pcreux" and Title "Hello"' }
  expected: "All Posts with Author \"pcreux\" and Title \"Hello\""
       got: "All Posts with Title \"Hello\" and Author \"pcreux\"" (using ==)

Will fix... :-/

Owner

seanlinsley commented Dec 7, 2012

I think this might be a better way to visualize scopes and filters. It has the added benefit of not running out of space, like your solution above inevitably would with a complex query--especially if it involved date range searching.

That's just a proof-of-concept, with some good old hackery:

sidebar "Search Status" do
  span do 
    h4 "Scope:", style: "display: inline"
    b "All",     style: "display: inline"
  end
  div style: "margin-top: 10px" do
    h4  "Current filters", style: "margin-bottom: 10px"
    b   "Email:",          style: "padding-left: 20px"
    div '"lotsa stuff"',   style: "display: inline"
  end
end
Owner

seanlinsley commented Dec 9, 2012

@pcreux, what do you think of my mockup? Do you want to implement it? I'm fine either way. Assuming we work together, is it possible to share a pull request?

@seanlinsley seanlinsley referenced this pull request Apr 18, 2013

Closed

Search Status Sidebar #2122

Owner

seanlinsley commented Apr 18, 2013

Replaced by #2122

@seanlinsley seanlinsley deleted the filter-context branch Jul 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment