singularize "New ______" Button #1898

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

Hey, I'm not sure if this is the right spot for it... but I'm getting a         
'New Deadlines' button in my admin panel instead of a 'New Deadline'            
one. Adding this change with bundle open activeadmin fixes the problem        
without any obvious side-effects.  Note: I'm not sure if anywhere else          
needs to be changed. 

singularize "New ______" Button
Hey, I'm not sure if this is the right spot for it... but I'm getting a         
'New Deadlines' button in my admin panel instead of a 'New Deadline'            
one. Adding this change with `bundle open activeadmin` fixes the problem        
without any obvious side-effects.  Note: I'm not sure if anywhere else          
needs to be changed. 

Hmm... "Deadlines was successfully destroyed." shows up as well. I'll have to look into that.

Contributor

macfanatic commented Mar 4, 2013

Could you add some specs for this use case? I would also look around, I believe there's probably a method that returns the singularized resource that you're looking for.

A basic example of the resource you're registering with AA would also be good.

Ok, I'll try to get an example going and a pull request that passes

Owner

seanlinsley commented Mar 11, 2013

Note that our CI builds aren't passing in and of themselves. If you can get rspec and cucmber tests passing on your side, that will be good enough.

Ok thanks. I'll let you know then when I have an example up and a decent
patch ready. Hopefully by this weekend :)

On Mon, Mar 11, 2013 at 11:23 AM, Sean Ian Linsley <notifications@github.com

wrote:

Note that our CI builds aren't passing in and of themselves. If you can
get rspec and cucmber tests passing on your side, that will be good enough.


Reply to this email directly or view it on GitHubhttps://github.com/gregbell/active_admin/pull/1898#issuecomment-14723174
.

Owner

seanlinsley commented Mar 15, 2013

Our Travis builds on master are now green (as of 166bc46). Please rebase your PR on the current master:

# Expectations: "upstream" is gregbell's GitHub repo and "origin" is your fork

# Rebase your fork's master branch with the latest upstream changes
git checkout master
git pull --rebase upstream master
git push origin master

# Rebase your feature branch with the latest upstream changes
git checkout your_feature_branch
git pull --rebase upstream master
git push origin your_feature_branch # note that you may need to use -f
Owner

seanlinsley commented Apr 25, 2013

This is out of date, so I'm going to close it. If this is still an issue and you still want to get it fixed, please update this PR with my directions above, and add failing unit tests for this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment