improved IE7 support #1922

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

romansklenar commented Feb 14, 2013

I know that we support IE8+ but now AA is unusable in IE7, see the screenshots.

Screen Shot 2013-02-14 at 15 55 39

This patch makes heal AA from these pains in this legacy browser.

Screen Shot 2013-02-14 at 15 55 29

Owner

seanlinsley commented Feb 14, 2013

Oh wow, that's much better!

What does that * syntax do?

Contributor

romansklenar commented Feb 14, 2013

It's an ugly IE7 hack. The problem might be that it's not CSS valid.
Maybe it will be a good idea to consider IE-only stylesheet(s) through conditional comments in layout for better targeting of specific IE versions. Something like:

<!--[if lte IE 7]> <html class="ie7"> <![endif]-->
<!--[if IE 8]>     <html class="ie8"> <![endif]-->
<!--[if IE 9]>     <html class="ie9"> <![endif]-->
<!--[if !IE]><!--> <html>             <!--<![endif]-->

Should we be adding support for a browser that has usage of less that 1% globally?

Owner

seanlinsley commented Feb 16, 2013

@SebAshton, if it's not a huge pain to make AA look somewhat reasonable on IE 7, then why not?

I've run into corporations that still install XP for new employees. There's no need to intentionally alienate them.

Owner

seanlinsley commented Mar 15, 2013

Our Travis builds on master are now green (as of 166bc46). Please rebase your PR on the current master:

# Expectations: "upstream" is gregbell's GitHub repo and "origin" is your fork

# Rebase your fork's master branch with the latest upstream changes
git checkout master
git pull --rebase upstream master
git push origin master

# Rebase your feature branch with the latest upstream changes
git checkout your_feature_branch
git pull --rebase upstream master
git push origin your_feature_branch # note that you may need to use -f
Contributor

romansklenar commented Mar 15, 2013

Rebased.

Owner

seanlinsley commented Apr 16, 2013

Meh. Closing this I guess.

Contributor

romansklenar commented Apr 16, 2013

It's not going to be merged?

Owner

seanlinsley commented Apr 16, 2013

The number of IE 7 users is pretty low, and this seems like a bad hack to let into the codebase.

Seems like anyone that absolutely has to support IE 7 can copy-paste the CSS rules in this PR into their application. Actually, @romansklenar, why not make a wiki page showing how to do just that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment