Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

improved IE7 support #1922

Closed
wants to merge 1 commit into from

3 participants

@romansklenar

I know that we support IE8+ but now AA is unusable in IE7, see the screenshots.

Screen Shot 2013-02-14 at 15 55 39

This patch makes heal AA from these pains in this legacy browser.

Screen Shot 2013-02-14 at 15 55 29

@seanlinsley
Owner

Oh wow, that's much better!

What does that * syntax do?

@romansklenar

It's an ugly IE7 hack. The problem might be that it's not CSS valid.
Maybe it will be a good idea to consider IE-only stylesheet(s) through conditional comments in layout for better targeting of specific IE versions. Something like:

<!--[if lte IE 7]> <html class="ie7"> <![endif]-->
<!--[if IE 8]>     <html class="ie8"> <![endif]-->
<!--[if IE 9]>     <html class="ie9"> <![endif]-->
<!--[if !IE]><!--> <html>             <!--<![endif]-->
@SebAshton

Should we be adding support for a browser that has usage of less that 1% globally?

@seanlinsley
Owner

@SebAshton, if it's not a huge pain to make AA look somewhat reasonable on IE 7, then why not?

I've run into corporations that still install XP for new employees. There's no need to intentionally alienate them.

@seanlinsley
Owner

Our Travis builds on master are now green (as of 166bc46). Please rebase your PR on the current master:

# Expectations: "upstream" is gregbell's GitHub repo and "origin" is your fork

# Rebase your fork's master branch with the latest upstream changes
git checkout master
git pull --rebase upstream master
git push origin master

# Rebase your feature branch with the latest upstream changes
git checkout your_feature_branch
git pull --rebase upstream master
git push origin your_feature_branch # note that you may need to use -f
@romansklenar

Rebased.

@seanlinsley
Owner

Meh. Closing this I guess.

@romansklenar

It's not going to be merged?

@seanlinsley
Owner

The number of IE 7 users is pretty low, and this seems like a bad hack to let into the codebase.

Seems like anyone that absolutely has to support IE 7 can copy-paste the CSS rules in this PR into their application. Actually, @romansklenar, why not make a wiki page showing how to do just that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 15, 2013
  1. @romansklenar

    improved IE7 support

    romansklenar authored
This page is out of date. Refresh to see the latest.
View
2  app/assets/stylesheets/active_admin/_header.css.scss
@@ -50,6 +50,8 @@
& > li {
display: inline-block;
+ *display: inline;
+ zoom: 1;
margin-right: 4px;
font-size: 1.0em;
position: relative;
View
4 app/assets/stylesheets/active_admin/components/_table_tools.css.scss
@@ -46,12 +46,16 @@ a.table_tools_button, .table_tools .dropdown_menu_button {
.table_tools_segmented_control {
display: inline-block;
+ *display: inline;
+ zoom: 1;
list-style-type: none;
margin: 0;
padding: 0;
li {
display: inline-block;
+ *display: inline;
+ zoom: 1;
list-style-image: none;
list-style-type: none;
margin-left: -7px;
View
2  app/assets/stylesheets/active_admin/structure/_main_structure.scss
@@ -16,7 +16,7 @@
}
}
- &.without_sidebar #main_content_wrapper #main_content{ margin-right: 0; }
+ &.without_sidebar #main_content_wrapper #main_content{ margin-right: 1px; }
#sidebar {
float: left;
View
5 app/assets/stylesheets/active_admin/structure/_title_bar.scss
@@ -6,6 +6,7 @@
display: table;
border-bottom-color: #EEE;
width: 100%;
+ *width: auto;
position: relative;
margin: 0;
margin-bottom: 15px;
@@ -16,10 +17,13 @@
height: 50px;
vertical-align: middle;
display: table-cell;
+ *display: block;
+ *float: left;
}
#titlebar_right {
text-align: right;
+ *float: right;
}
h2 {
@@ -27,6 +31,7 @@
padding: 0;
font-size: 2.6em;
font-weight: bold;
+ *line-height: 1.2em;
}
.action_items {
Something went wrong with that request. Please try again.