Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing spaces #1948

Closed
wants to merge 10 commits into from
Closed

Remove trailing spaces #1948

wants to merge 10 commits into from

Conversation

ai
Copy link
Contributor

@ai ai commented Feb 27, 2013

Trailing spaces are prohibited in most style guides: Rails, GitHub.

I remove it by script and then recheck fixes.

find . -name "*" | xargs egrep -s ".* +$"

Also I stay vendor JS in original view with trailing spaces.

@seanlinsley
Copy link
Contributor

@ai, this can't be applied cleanly anymore because of recent changes. Please rebase & rerun that script on master.

@ai ai closed this Mar 5, 2013
@ai
Copy link
Contributor Author

ai commented Mar 5, 2013

Rebased

@ai ai reopened this Mar 5, 2013
@ai
Copy link
Contributor Author

ai commented Mar 5, 2013

Please, don’t wait for pull, because after few day I will need again to rebase fixes.

@ai
Copy link
Contributor Author

ai commented Mar 11, 2013

@daxter @macfanatic I will need another rebase soon :(. What can I else do for this pull request?

@seanlinsley
Copy link
Contributor

This is going to have to wait unfortunately. We're trying to get our test builds with Travis CI working again, and tons of changed lines of code is only going to make that more difficult.

@seanlinsley
Copy link
Contributor

Superseded by #2107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants