table ids are now prefixed by "index_table_" to correct HTML document validity #1966

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants

as discussed here: gregbell#1965 (comment)

It would be good though to the IndexTableFor class being specced in isolation.

Tiago Cardoso changed the id format of the index tables, thereby correcting the val…
…idity of the generated HTML, which was seeing the same id being attributed multiple times in the same document
c3330c6
Contributor

macfanatic commented Mar 5, 2013

Looks good, will make sure the tests pass & merge in when I get a chance.

@exviva exviva and 1 other commented on an outdated diff Mar 5, 2013

lib/active_admin/views/index_as_table.rb
@@ -108,8 +108,9 @@ module Views
class IndexAsTable < ActiveAdmin::Component
def build(page_presenter, collection)
+ debugger
@exviva

exviva Mar 5, 2013

Contributor

Oops

@macfanatic

macfanatic Mar 5, 2013

Contributor

Good eye, was just testing locally & noticed that

@tiagocardoso1983 - will you amend your commit to remove that & force a push back up to this branch?

Owner

seanlinsley commented Mar 5, 2013

Speaking of, @macfanatic do you have any idea what's wrong with our Travis builds?

Contributor

macfanatic commented Mar 5, 2013

@daxter - I'm not familiar with Travis, but I can see for instance that there are 15 cukes that fail, related to filters & scoping of index listings. Was going to pair with someone to see what could be done about that.

ups, sorry about that, will take care of it.

hope there's no more garbage left :)

macfanatic closed this Mar 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment