Because it needed doing.
all green 🍀
RSpec has been standard issue for a while, so `should` is a given
a little negation goes a long way
get rid of unused code
one more down!
better factory steps
reshape tests & refactor `spec/support/rails_template.rb`
+ tests changed to expect the User's full name, instead of their username
+ added `display_name` to Post class in rails template application
+ refactored the rails template generator so it's actually readable by humans
batch actions cuke step refactor
I had to rebase on the current upstream master, as there were conflicts with the changes in #2034.
There was one file I hadn't gotten to yet, hence there being a remaining TODO in the diff.
Looked through everything but didn't pay attention to the comment on that. Everything else looked good & tests pass, so feel free to refactor even more later.
FYI for anyone that's running into failing tests as of this commit, you need to remove the old rails test app so it can be recreated:
rm -r spec/rails