Cucumber cleanup #2015

Merged
merged 10 commits into from Apr 11, 2013

Projects

None yet

2 participants

@seanlinsley
Member

Because it needed doing.

@seanlinsley
Member

all green 🍀

@seanlinsley
Member

I had to rebase on the current upstream master, as there were conflicts with the changes in #2034.

@macfanatic macfanatic merged commit db43bf7 into activeadmin:master Apr 11, 2013

1 check passed

default The Travis build passed
Details
@seanlinsley
Member

There was one file I hadn't gotten to yet, hence there being a remaining TODO in the diff.

@macfanatic
Contributor

Looked through everything but didn't pay attention to the comment on that. Everything else looked good & tests pass, so feel free to refactor even more later.

@seanlinsley seanlinsley deleted the unknown repository branch Apr 12, 2013
@seanlinsley
Member

FYI for anyone that's running into failing tests as of this commit, you need to remove the old rails test app so it can be recreated:

rm -r spec/rails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment