remove unused Batch Actions code #2021

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@seanlinsley
Member

This removes a set of Batch Actions code that isn't actually being used. If someone besides myself could download this branch and test it out, I'd appreciate it.

This spawned from #2016, where I noticed that there was duplicate Ruby and JS code just laying about.

/cc @macfanatic

@seanlinsley
Member

Closing this as @macfanatic has already removed this code on the switch-to-bootstrap branch on the @reverbhq fork.

@seanlinsley seanlinsley deleted the unknown repository branch Mar 28, 2013
@javierjulio
Contributor

@timoschilling looks like this wasn't ever merged in but this should verify that the popover related code can be safely removed as @seanlinsley had done it but stopped due to the switch-to-bootstrap effort which now has seemed to have died out. If you're good with me removing the popover code I'll do it in my CSS WIP branch unless you prefer I do it separately (although if it was deemed unused so long ago can't see how it would be an issue to just remove now from my branch).

@timoschilling
Member

@javierjulio remove it, but pleas do it in a separately PR

@timoschilling
Member

@javierjulio pleas ref this PR in your one

@javierjulio javierjulio added a commit to javierjulio/activeadmin that referenced this pull request Apr 10, 2015
@javierjulio javierjulio Remove popover component and related code
The popover component has since been replaced with dropdown menu so
this is no longer needed or supported. Renamed
batch_action_popover_spec to batch_action_selector_spec to test the
correct existing class. These changes include those started in
@seanlinsley’s original PR #2021 which wasn’t merged in because at the
time there was work being done on migrating AA to use Bootstrap that
has since remained incomplete and inactive.
7063142
@davidlawson davidlawson added a commit to davidlawson/activeadmin that referenced this pull request Apr 16, 2015
@javierjulio @davidlawson javierjulio + davidlawson Remove popover component and related code
The popover component has since been replaced with dropdown menu so
this is no longer needed or supported. Renamed
batch_action_popover_spec to batch_action_selector_spec to test the
correct existing class. These changes include those started in
@seanlinsley’s original PR #2021 which wasn’t merged in because at the
time there was work being done on migrating AA to use Bootstrap that
has since remained incomplete and inactive.
0b80844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment