Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds jquery-ui-rails as a dependency #2233

Conversation

@nebirhos
Copy link
Contributor

commented May 29, 2013

Fixes #2232

@seanlinsley

This comment has been minimized.

Copy link
Member

commented May 29, 2013

Do you have any idea why Travis hasn't run for this pull request?

This can't be immediately merged since jquery-ui-rails requires railties >= 3.1.0, and we support Rails 3.0

Related to #2028.

@seanlinsley

This comment has been minimized.

Copy link
Member

commented May 29, 2013

I'd like to have at least one tiny release before bumping the minor version number, and removing support for Rails 3.0, so I'm going to set this PR to the AA 0.7.0 milestone.

@vjaykoogu

This comment has been minimized.

Copy link

commented May 30, 2013

yep this gem is must. otherwise it shows me this

Sprockets::FileNotFound at /
couldn't find file 'jquery-ui'
( **************************************************/gems/activeadmin-0.6.0/app/assets/javascripts/active_admin/base.js:2)

@nebirhos

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2013

Ok, in the meanwhile we can force the jquery-rails version in the gemspec

@jamonholmgren

This comment has been minimized.

Copy link

commented May 30, 2013

We just did this in our app's Gemfile:

gem "jquery-rails", "2.3.0"
@seanlinsley

This comment has been minimized.

Copy link
Member

commented May 30, 2013

BTW if you're tracking master, #2235 applied a temporary fix.

@vjaykoogu

This comment has been minimized.

Copy link

commented May 31, 2013

thanks alot @jamonholmgren it workd... :)

@t0rpedo

This comment has been minimized.

Copy link

commented Jun 4, 2013

@jamonholmgren Thanks much!

@jamonholmgren

This comment has been minimized.

Copy link

commented Jun 4, 2013

No problem!

@seanlinsley

This comment has been minimized.

Copy link
Member

commented Jun 20, 2013

BTW @nebirhos I included your commit in #1979, which will be the base of a rails4 branch once I get it fully updated.

@nebirhos

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2013

thank you! 🤘

@fred

This comment has been minimized.

Copy link

commented Jul 18, 2013

by the way, you dont have to include jquery.ui.all in active admin base.js
I'm only using this on my branch

//= require jquery.ui.core
//= require jquery.ui.widget
//= require jquery.ui.datepicker
@seanlinsley

This comment has been minimized.

Copy link
Member

commented Sep 20, 2013

This is part of the rails4 branch, so I'm going to close this.

htaidirt pushed a commit to htaidirt/helios that referenced this pull request Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.