Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add header_action method for panels #2723

Merged
merged 2 commits into from May 29, 2014

Conversation

Projects
None yet
3 participants
Contributor

shekibobo commented Nov 22, 2013

Rough implementation that seems to work. No tests yet, but wanted to open #2552 for discussion over actual code.

Coverage Status

Coverage decreased (-0.07%) when pulling 59ec491 on shekibobo:2552-panel-header-actions into e9b7c47 on gregbell:master.

Owner

seanlinsley commented May 5, 2014

Closing this as stale

@seanlinsley seanlinsley closed this May 5, 2014

Contributor

shekibobo commented May 6, 2014

I just updated this branch and added tests for this over on shekibobo:2552-panel-header-actions, but it doesn't show up here (probably because it's closed). I would like to revisit this, as far as the DSL or advanced implementation goes. Any thoughts?

@seanlinsley seanlinsley reopened this May 6, 2014

Contributor

shekibobo commented May 28, 2014

I've reworked this a bit and added better tests to make sure it all works right. Any thoughts on what it might take to get this (or some version of it) pulled into master?

Owner

seanlinsley commented May 29, 2014

I'm still not happy with the user-facing DSL, but there's no point in letting that block an undeniably useful feature. Thanks! 🐱

seanlinsley added a commit that referenced this pull request May 29, 2014

@seanlinsley seanlinsley merged commit 4bca96f into activeadmin:master May 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Contributor

shekibobo commented May 29, 2014

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment