Test against JRuby and Rubinius #2859

Closed
wants to merge 1 commit into
from

3 participants

@seanlinsley
Active Admin member
@seanlinsley
Active Admin member

Oh wow JRuby got really far this time:

Failures:

  1) Memory Leak should not leak ActiveAdmin::Namespace
     Failure/Error: ObjectSpace.each_object(klass) { }
     RuntimeError:
       ObjectSpace is disabled; each_object will only work with Class, pass -X+O to enable
     # ./spec/integration/memory_spec.rb:9:in `count_instances_of'
     # ./spec/integration/memory_spec.rb:16:in `it_should_not_leak'

  2) Memory Leak should not leak ActiveAdmin::Resource
     Failure/Error: ObjectSpace.each_object(klass) { }
     RuntimeError:
       ObjectSpace is disabled; each_object will only work with Class, pass -X+O to enable
     # ./spec/integration/memory_spec.rb:9:in `count_instances_of'
     # ./spec/integration/memory_spec.rb:16:in `it_should_not_leak'

Finished in 7.49 seconds
11 examples, 2 failures

Failed examples:

rspec ./spec/integration/memory_spec.rb:13 # Memory Leak should not leak ActiveAdmin::Namespace
rspec ./spec/integration/memory_spec.rb:13 # Memory Leak should not leak ActiveAdmin::Resource
@seanlinsley
Active Admin member

Before I rebase on master, some context:

screen shot 2014-05-23 at 6 47 07 pm

screen shot 2014-05-23 at 6 47 18 pm

@kennethkalmer

@seanlinsley is there anything we can do to resurrect this effort?

@timoschilling
Active Admin member

@kennethkalmer I think @seanlinsley no longer work on this. @dmitry is working on a new rubinius support in #3742. You can help him or create a new new PR to support JRruby

@timoschilling
Active Admin member

@kennethkalmer you can pick up commits from @seanlinsley if they helpfull and create a WIP PR like @dmitry does

@kennethkalmer

Just opened #3792 for a wip-style progress report. Actually getting the tests running has been surprisingly easy

@timoschilling
Active Admin member

closed while continued in #3792 jRuby and #3742 Rubinius

@timoschilling timoschilling deleted the test-more-rubies branch Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment