Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Test against JRuby and Rubinius #2859

Closed
wants to merge 1 commit into from

3 participants

@seanlinsley
Owner
@seanlinsley
Owner

Oh wow JRuby got really far this time:

Failures:

  1) Memory Leak should not leak ActiveAdmin::Namespace
     Failure/Error: ObjectSpace.each_object(klass) { }
     RuntimeError:
       ObjectSpace is disabled; each_object will only work with Class, pass -X+O to enable
     # ./spec/integration/memory_spec.rb:9:in `count_instances_of'
     # ./spec/integration/memory_spec.rb:16:in `it_should_not_leak'

  2) Memory Leak should not leak ActiveAdmin::Resource
     Failure/Error: ObjectSpace.each_object(klass) { }
     RuntimeError:
       ObjectSpace is disabled; each_object will only work with Class, pass -X+O to enable
     # ./spec/integration/memory_spec.rb:9:in `count_instances_of'
     # ./spec/integration/memory_spec.rb:16:in `it_should_not_leak'

Finished in 7.49 seconds
11 examples, 2 failures

Failed examples:

rspec ./spec/integration/memory_spec.rb:13 # Memory Leak should not leak ActiveAdmin::Namespace
rspec ./spec/integration/memory_spec.rb:13 # Memory Leak should not leak ActiveAdmin::Resource
@seanlinsley
Owner

Before I rebase on master, some context:

screen shot 2014-05-23 at 6 47 07 pm

screen shot 2014-05-23 at 6 47 18 pm

@kennethkalmer

@seanlinsley is there anything we can do to resurrect this effort?

@timoschilling

@kennethkalmer I think @seanlinsley no longer work on this. @dmitry is working on a new rubinius support in #3742. You can help him or create a new new PR to support JRruby

@timoschilling

@kennethkalmer you can pick up commits from @seanlinsley if they helpfull and create a WIP PR like @dmitry does

@kennethkalmer

Just opened #3792 for a wip-style progress report. Actually getting the tests running has been surprisingly easy

@timoschilling

closed while continued in #3792 jRuby and #3742 Rubinius

@timoschilling timoschilling deleted the test-more-rubies branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 23, 2014
  1. @seanlinsley @timoschilling

    test against JRuby and Rubinius

    seanlinsley authored timoschilling committed
This page is out of date. Refresh to see the latest.
Showing with 12 additions and 2 deletions.
  1. +2 −0  .travis.yml
  2. +5 −2 Gemfile
  3. +5 −0 spec/requests/memory_spec.rb
View
2  .travis.yml
@@ -12,6 +12,8 @@ script:
rvm:
- 1.9.3
- 2.1.2
+ - rbx-2
+ - jruby
env:
matrix:
- RAILS=3.2.19
View
7 Gemfile
@@ -1,5 +1,4 @@
source 'https://rubygems.org'
-
gemspec
require File.expand_path 'spec/support/detect_rails_version', File.dirname(__FILE__)
@@ -17,6 +16,10 @@ gem 'pundit'
gem 'rake', require: false
gem 'parallel_tests'
+gem RUBY_ENGINE =~ /jruby/ ? 'activerecord-jdbcsqlite3-adapter' : 'sqlite3'
+
+gem 'rubysl' if RUBY_ENGINE =~ /rbx/
+
group :development do
# Debugging
gem 'pry' # Easily debug from your console with `binding.pry`
@@ -45,6 +48,6 @@ group :test do
gem 'rails-i18n' # Provides default i18n for many languages
gem 'rspec'
gem 'rspec-rails'
+ gem 'rubinius-coverage' if RUBY_ENGINE =~ /rbx/ # colszowka/simplecov#250
gem 'shoulda-matchers'
- gem 'sqlite3'
end
View
5 spec/requests/memory_spec.rb
@@ -1,6 +1,11 @@
require 'rails_helper'
+<<<<<<< HEAD:spec/requests/memory_spec.rb
describe "Memory Leak", :type => :request do
+=======
+describe "Memory Leak" do
+ JRuby.objectspace = true if RUBY_ENGINE =~ /jruby/
+>>>>>>> test against JRuby and Rubinius:spec/integration/memory_spec.rb
def count_instances_of(klass)
ObjectSpace.each_object(klass) { }
Something went wrong with that request. Please try again.