Add xdan-datetimepicker-rails and datetime_picker input #3000

shekibobo · 2014-03-13T00:40:45Z

Adds XDSoft's DateTime picker as the combined_date_time_picker input for forms.

IRC prompting this PR.

Please try this out and see if there's any tweaks or suggestions to better implement this, or if you notice any bugs.

shekibobo · 2014-03-13T18:06:28Z

This is ready for review, if anyone wants to try it out.

shekibobo · 2014-03-17T18:53:46Z

Works as expected as a drop-in replacement for datepicker (accepts the same basic options, etc). Time format looks like 2014-03-17 14:50 by default, but can be overridden by overriding format on the datepicker_options and input_html/value on the combined_date_time_picker arguments.

Tests work (and fixed one spec that wasn't even running before).

shekibobo · 2014-03-17T18:57:19Z

If this looks good, I might also consider changing the default datetime filter field to provide more precise time-based filtering. Thoughts?

shekibobo · 2014-03-18T19:41:21Z

Figured out I was loading the datetime picker wrong. This one is meant to load whenever the page loads. I changed it so that it now loads whenever the page is loaded and whenever a has_many fieldset is loaded containing a combined_date_time_picker field. Now the field can properly accept options like mask: true.

seanlinsley · 2014-04-14T02:10:42Z

Sorry I haven't gotten around to reviewing this :-( I should have the time to do it justice this coming week.

timoschilling · 2014-04-16T11:59:54Z

Nice! But I think AA should not have to manny dependencies!

To make a activeadmin-xdan-datetimepicker gem could be a good way.

seanlinsley · 2014-04-16T16:15:49Z

If we can make this completely replace the existing datepicker, I'm fine adding this as a required dependency. It's much more feature-complete than what we have now.

shekibobo · 2014-04-16T21:57:23Z

I might be able to make that happen this weekend.

shekibobo · 2014-04-18T16:12:52Z

IRC

seanlinsley · 2014-04-24T03:50:16Z

Let me know if you need someone to bounce ideas off of 🐱

shekibobo · 2014-04-24T04:31:04Z

At this point I really want to figure out a good way to make formats match between the input and the picker. That might mean figuring out a converter. It might mean splitting off another fork of xdan's repo with the formatter/parser replaced with one more Ruby-friendly. Unfortunately Javascript isn't my strong suit, so it may take some time to figure out on my own, but I plan on digging into it as soon as I get some time to dedicate to it.

seanlinsley · 2014-04-30T16:37:03Z

IRT time formats, I've found that Y-m-d g:i A works well with Rails. Though it looks like this plugin doesn't support time zones at all 😦

seanlinsley · 2014-08-24T16:22:48Z

I'd really love to have this as part of Active Admin. Do you have the time to rebase it?

shekibobo · 2014-08-24T18:17:47Z

I can try to rebase it, but I'm not sure it's ready to be merged in yet. I probably won't have time to look at it today, but probably some time later this week.

seanlinsley · 2014-08-24T18:22:12Z

No rush. Just wanted to make sure you're still around to work on this 🐙

shekibobo · 2014-08-24T18:23:34Z

Yup, still here. Just not a lot of time to delve into AA source lately.

shekibobo · 2014-08-25T19:51:49Z

Rebased with minimal issues.

Again, I don't really have a whole lot of time right now to look into this, but the issue of the date-time format should probably be addressed, and I'd be open to ideas on how we might solve that problem. I remember seeing someone post a conversion script (can't remember what issue, or if it was even here), and that might be worth exploring.

This also does not replace the current datetime picker, nor the form inputs. However, I think this would be a huge improvement to the form datetime inputs, since it would allow users to filter by a specific range of time within a day as well as by the date, and also solve the issue of searching with the same date in the start and end fields.

shekibobo · 2014-08-25T20:02:44Z

On the other hand, we could just merge this in and start dealing with issues as they come. Maybe the concerns I have will be minor, but enough of a pain point for someone else that has time to tackle it before I do. 🐱

This will now go through the page and find all fields which will use the combined date-time picker and set them up on page load. It will also go through and find relevant fields to set up whenever a has_many field is added.

shekibobo · 2014-09-02T17:36:02Z

I've updated this to use the combined picker for date range filters.

timoschilling · 2014-11-02T01:43:36Z

lib/active_admin/inputs/combined_date_time_picker_input.rb

Why it is named CombinedDateTimePickerInput and not only DateTimePickerInput?

For backwards compatability. There is already a datetimepicker.

On Sat, Nov 1, 2014, 9:43 PM Timo Schilling notifications@github.com
wrote:

In lib/active_admin/inputs/combined_date_time_picker_input.rb:

@@ -0,0 +1,28 @@
+module ActiveAdmin

module Inputs

class CombinedDateTimePickerInput < ::Formtastic::Inputs::StringInput

Why it is named CombinedDateTimePickerInput and not only
DateTimePickerInput?

—
Reply to this email directly or view it on GitHub
https://github.com/activeadmin/activeadmin/pull/3000/files#r19709171.

There is a DatepickerInput, but I can't find a DateTimePickerInput

Fivell · 2015-02-12T22:16:20Z

@shekibobo , do you need any help ? This feature is very cool, hope it will be merged soon

shekibobo · 2015-02-16T14:25:35Z

hey, sorry for falling off the planet for a while. I haven't really been working in ActiveAdmin for a few months now (actually working in Android these days), so I haven't really had a lot of time to focus on this.

I have been seeing more activity on the timepicker lately, and I've been meaning to look into it to see if new work would mean easier integration. I will try to update my gem repo for xdan-datetimepicker today, but if anyone else would like to take up this torch, I'd really appreciate it, but honestly I'm probably not going to have the free time to work past the challenges for this integration.

That being said, the README for the gem does include some examples on how to integrate the timepicker using both formtastic and simple_form, which I had mostly extracted from this PR and used in my own projects that used AA.

Fivell · 2015-03-15T11:56:29Z

I continue working on this feature here https://github.com/Fivell/activeadmin/tree/timepicker

CombinedDateTimePickerInput renamed to DateTimePickerInput
fixed specs and cucumber features
undo deletion of DatePicker while DateTimePickerInput integration is not completed.

If somebody want's to play with it you can use this branch or plugin https://github.com/ActiveAdminPlugins/activeadmin_datetimepicker

Things todo before even thinking to merge to AA

restyle datetimepicker using AA styles, respecting sass variables and so on (this is where I need community help)
replace datepicker with date_time_picker (can be customised even for time picker )

timoschilling · 2015-03-16T12:40:58Z

While @Fivell has released a integration as gem, I no longer see a reason for this PR

shekibobo mentioned this pull request May 8, 2014

3123 configurable datepicker input value field #3124

Closed

shekibobo mentioned this pull request Jun 3, 2014

Fix broken datepicker specs #3187

Merged

seanlinsley added the 4 - Review label Aug 24, 2014

seanlinsley added 2 - Stalled and removed 4 - Review labels Aug 24, 2014

shekibobo force-pushed the xdan-datepicker branch from b600cfa to 5f62a1f Compare August 25, 2014 19:42

shekibobo added 5 commits September 1, 2014 00:10

Add xdan-datetimepicker-rails and datetime_picker input

79c7c70

Rename to combined_date_time_picker, add specs

a89e748

Fix the broken datepicker and combined_date_time_picker specs

b8b8379

Add docs for combined date-time picker

e2de4bd

Properly add datetimepicker to its fields

972588b

This will now go through the page and find all fields which will use the combined date-time picker and set them up on page load. It will also go through and find relevant fields to set up whenever a has_many field is added.

shekibobo force-pushed the xdan-datepicker branch from 5f62a1f to 972588b Compare September 1, 2014 04:11

seanlinsley added 3 - Working and removed 2 - Stalled labels Sep 1, 2014

Use combined-date-time-picker for filters

dfb1de1

shekibobo force-pushed the xdan-datepicker branch from ef29ad1 to dfb1de1 Compare September 1, 2014 05:02

timoschilling reviewed Nov 2, 2014
View reviewed changes

timoschilling closed this Mar 16, 2015

timoschilling removed the workaround label Mar 16, 2015

Uh oh!

Add xdan-datetimepicker-rails and datetime_picker input #3000

Add xdan-datetimepicker-rails and datetime_picker input #3000

Uh oh!

Conversation

shekibobo commented Mar 13, 2014

Uh oh!

shekibobo commented Mar 13, 2014

Uh oh!

shekibobo commented Mar 17, 2014

Uh oh!

shekibobo commented Mar 17, 2014

Uh oh!

shekibobo commented Mar 18, 2014

Uh oh!

seanlinsley commented Apr 14, 2014

Uh oh!

timoschilling commented Apr 16, 2014

Uh oh!

seanlinsley commented Apr 16, 2014

Uh oh!

shekibobo commented Apr 16, 2014

Uh oh!

shekibobo commented Apr 18, 2014

Uh oh!

seanlinsley commented Apr 24, 2014

Uh oh!

shekibobo commented Apr 24, 2014

Uh oh!

seanlinsley commented Apr 30, 2014

Uh oh!

seanlinsley commented Aug 24, 2014

Uh oh!

shekibobo commented Aug 24, 2014

Uh oh!

seanlinsley commented Aug 24, 2014

Uh oh!

shekibobo commented Aug 24, 2014

Uh oh!

shekibobo commented Aug 25, 2014

Uh oh!

shekibobo commented Aug 25, 2014

Uh oh!

shekibobo commented Sep 2, 2014

Uh oh!

timoschilling Nov 2, 2014

Choose a reason for hiding this comment

Uh oh!

shekibobo Nov 2, 2014

Choose a reason for hiding this comment

Uh oh!

timoschilling Nov 2, 2014

Choose a reason for hiding this comment

Uh oh!

Fivell commented Feb 12, 2015

Uh oh!

shekibobo commented Feb 16, 2015

Uh oh!

Fivell commented Mar 15, 2015

Uh oh!

timoschilling commented Mar 16, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants