Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous coffeescript leading to occasional javascript errors #3776

Merged
merged 2 commits into from Jan 30, 2015

Conversation

@aaronsakowski
Copy link
Contributor

commented Jan 30, 2015

I'be been running into an occasional problem where suddenly my javascript checkboxes and batch actions will stop working. I traced this to the fact that the coffeescript appears to be ambiguous in it's use of the "options" variable. This leads to the coffeescript compiler sometimes producing the correct javascript and sometimes producing javascript that results in an "unknown variable" error.

timoschilling added a commit that referenced this pull request Jan 30, 2015
Merge pull request #3776 from aaronsakowski/master
Ambiguous coffeescript leading to occasional javascript errors

@timoschilling timoschilling merged commit b3a9f4b into activeadmin:master Jan 30, 2015

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
hound Hound has reviewed the changes.
timoschilling added a commit that referenced this pull request Feb 2, 2015
timoschilling added a commit that referenced this pull request Feb 2, 2015
antob added a commit to antob/activeadmin that referenced this pull request May 28, 2015
bluerabbit added a commit to nexway/activeadmin that referenced this pull request Jun 1, 2015
Fix to prevent coffeescript from miss interpreting
See: activeadmin#3776
coffee-script version 1.9.0
> Changed strategy for the generation of internal compiler variable names. Note that this means that  function parameters are no longer available as naked example variables within the function body.
http://coffeescript.org/#changelog
@supremebeing7 supremebeing7 referenced this pull request Feb 6, 2017
snow added a commit to mycolorway/activeadmin that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.