Change the way of assigning template variables #4633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionView::Base#assign
method removes all previous view variable assigned from ActionView::Baseassigns
hash if there are any.For example:
This PR changes the way of assigning template variables, to avoid previously assigned values loss:
One of possible problems that this PR solves (reproduction steps):
has_many
method callstemplate.assign(...)
method, which clears template'sassigns
hash, sotemplate.assigns[:page_title]
returns nil.Note
This way (provided by this PR) of assigning template variables does not add an instance variable to the ActionView::Base object (template). If it is needed to add an instance variable, the solution should be like this:
But I think it is not necessary, because in all cases when the assignment is performed the variables are not used as instance variables in the view and are not assigned for this purpose.