Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependency detection #5670

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
3 participants
@timoschilling
Copy link
Member

commented Jan 23, 2019

fixes: #5209

@timoschilling timoschilling requested a review from deivid-rodriguez Jan 23, 2019

@timoschilling timoschilling merged commit 3fa45b0 into master Jan 23, 2019

24 checks passed

ci/circleci: jruby91rails50 Your tests passed on CircleCI!
Details
ci/circleci: jruby91rails51 Your tests passed on CircleCI!
Details
ci/circleci: jruby91rails52 Your tests passed on CircleCI!
Details
ci/circleci: jruby92rails50 Your tests passed on CircleCI!
Details
ci/circleci: jruby92rails51 Your tests passed on CircleCI!
Details
ci/circleci: jruby92rails52 Your tests passed on CircleCI!
Details
ci/circleci: lint_and_docs Your tests passed on CircleCI!
Details
ci/circleci: ruby23rails50 Your tests passed on CircleCI!
Details
ci/circleci: ruby23rails51 Your tests passed on CircleCI!
Details
ci/circleci: ruby23rails52 Your tests passed on CircleCI!
Details
ci/circleci: ruby24rails50 Your tests passed on CircleCI!
Details
ci/circleci: ruby24rails51 Your tests passed on CircleCI!
Details
ci/circleci: ruby24rails52 Your tests passed on CircleCI!
Details
ci/circleci: ruby25rails50 Your tests passed on CircleCI!
Details
ci/circleci: ruby25rails51 Your tests passed on CircleCI!
Details
ci/circleci: ruby25rails52 Your tests passed on CircleCI!
Details
ci/circleci: setup_coverage Your tests passed on CircleCI!
Details
ci/circleci: testapp50 Your tests passed on CircleCI!
Details
ci/circleci: testapp51 Your tests passed on CircleCI!
Details
ci/circleci: testapp52 Your tests passed on CircleCI!
Details
ci/circleci: upload_coverage Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (70% threshold)
Details
codeclimate/total-coverage 99% (0.0% change)
Details

@timoschilling timoschilling deleted the fix-dependency-detection branch Jan 23, 2019

@deivid-rodriguez

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

Should we actually add actionpack as a dependency? 🤔

@timoschilling

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2019

we have a implicit dependency through railties which should be enough

@deivid-rodriguez

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.