Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix db tasks on dev app #5697

Merged
merged 2 commits into from Mar 1, 2019

Conversation

Projects
None yet
2 participants
@deivid-rodriguez
Copy link
Member

deivid-rodriguez commented Mar 1, 2019

Fixes #5695 (comment).

deivid-rodriguez added some commits Mar 1, 2019

Fix db tasks on development application
`db` is a whole namespace, not a specific task.
Clarify that the command is not needed in the general case
Running `bin/rake local server` should automatically create a fresh new
test application and migrate the db.

@deivid-rodriguez deivid-rodriguez requested a review from activeadmin/maintainers Mar 1, 2019

@javierjulio
Copy link
Member

javierjulio left a comment

Thanks! 👍🏻

@javierjulio javierjulio merged commit 1329101 into master Mar 1, 2019

27 checks passed

ci/circleci: jruby91rails50 Your tests passed on CircleCI!
Details
ci/circleci: jruby91rails51 Your tests passed on CircleCI!
Details
ci/circleci: jruby91rails52 Your tests passed on CircleCI!
Details
ci/circleci: jruby92rails50 Your tests passed on CircleCI!
Details
ci/circleci: jruby92rails51 Your tests passed on CircleCI!
Details
ci/circleci: jruby92rails52 Your tests passed on CircleCI!
Details
ci/circleci: lint_and_docs Your tests passed on CircleCI!
Details
ci/circleci: ruby23rails50 Your tests passed on CircleCI!
Details
ci/circleci: ruby23rails51 Your tests passed on CircleCI!
Details
ci/circleci: ruby23rails52 Your tests passed on CircleCI!
Details
ci/circleci: ruby24rails50 Your tests passed on CircleCI!
Details
ci/circleci: ruby24rails51 Your tests passed on CircleCI!
Details
ci/circleci: ruby24rails52 Your tests passed on CircleCI!
Details
ci/circleci: ruby25rails50 Your tests passed on CircleCI!
Details
ci/circleci: ruby25rails51 Your tests passed on CircleCI!
Details
ci/circleci: ruby25rails52 Your tests passed on CircleCI!
Details
ci/circleci: ruby26rails50 Your tests passed on CircleCI!
Details
ci/circleci: ruby26rails51 Your tests passed on CircleCI!
Details
ci/circleci: ruby26rails52 Your tests passed on CircleCI!
Details
ci/circleci: setup_coverage Your tests passed on CircleCI!
Details
ci/circleci: testapp50 Your tests passed on CircleCI!
Details
ci/circleci: testapp51 Your tests passed on CircleCI!
Details
ci/circleci: testapp52 Your tests passed on CircleCI!
Details
ci/circleci: upload_coverage Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (70% threshold)
Details
codeclimate/total-coverage 99% (0.0% change)
Details

@javierjulio javierjulio deleted the fix_db_tasks_on_dev_app branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.