Try to fix stuck codeclimate coverage checks #6580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This action claims to work with codeclimate by inferring and setting the proper environment variables needed for codeclimate to be able to calculate diff coverages on their side.
Member
Author
|
It worked!! 🎉 |
Member
Author
|
I'm going to make another check though by creating a PR from my personal activeadmin fork to see if it works from there too (last time I had problems with that). |
Member
Author
|
Created a PR from my personal fork rebased on top of this one and it worked too, so it seems all fine! 🎉 |
Member
|
Awesome thanks! I take it we want to get this in first so I'll review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem seems to be that codeclimate's test-reporter doesn't support Github Actions. See qltysh-archive/test-reporter#406.
However, there's this action that claims to set the proper environment variables needed for codeclimate to calculate diff coverage.
So let's try it!