Issue #874 - Changed class name from "status" to "status_tag" #876

Merged
merged 1 commit into from Aug 22, 2012

Conversation

Projects
None yet
5 participants
@alansikora
Contributor

alansikora commented Dec 23, 2011

As described on the issue, there was a conflict between this css class and models named Status. The views became messy.

@alansikora

This comment has been minimized.

Show comment Hide comment
@alansikora

alansikora Feb 27, 2012

Contributor

So? Is this not relevant at all?

Contributor

alansikora commented Feb 27, 2012

So? Is this not relevant at all?

@futuretap

This comment has been minimized.

Show comment Hide comment
@futuretap

futuretap Mar 28, 2012

Please pull this into the main branch. I'm affected and annoyed by this issue, too!

Please pull this into the main branch. I'm affected and annoyed by this issue, too!

@hron84

This comment has been minimized.

Show comment Hide comment
@hron84

hron84 Mar 28, 2012

Contributor

+1

Contributor

hron84 commented Mar 28, 2012

+1

@alansikora

This comment has been minimized.

Show comment Hide comment
@alansikora

alansikora Apr 3, 2012

Contributor

So, what is this all about? Collaborative development or what?

Contributor

alansikora commented Apr 3, 2012

So, what is this all about? Collaborative development or what?

@jcuervo

This comment has been minimized.

Show comment Hide comment
@jcuervo

jcuervo Jun 1, 2012

Hope this gets merged soon. Thanks @alansikora for all the effort.

jcuervo commented Jun 1, 2012

Hope this gets merged soon. Thanks @alansikora for all the effort.

@alansikora

This comment has been minimized.

Show comment Hide comment
@alansikora

alansikora Jun 1, 2012

Contributor

Yeah, I gave up on Active Admin, unfortunately... Awesome work, but lack of attention, it has been 5 months since I sent this pull request. And the strange part is that people want this, and its a very simple CSS change...

Contributor

alansikora commented Jun 1, 2012

Yeah, I gave up on Active Admin, unfortunately... Awesome work, but lack of attention, it has been 5 months since I sent this pull request. And the strange part is that people want this, and its a very simple CSS change...

@hron84

This comment has been minimized.

Show comment Hide comment
@hron84

hron84 Jun 1, 2012

Contributor

Maybe @pcreux or @gregbell too busy for it... because of other, more important issues, I guess. Please be more patient, ActiveAdmin is not a simple project.

Contributor

hron84 commented Jun 1, 2012

Maybe @pcreux or @gregbell too busy for it... because of other, more important issues, I guess. Please be more patient, ActiveAdmin is not a simple project.

jpmckinney added a commit that referenced this pull request Aug 22, 2012

Merge pull request #876 from alansikora/master
Issue #874 - Changed class name from "status" to "status_tag"

@jpmckinney jpmckinney merged commit 5256219 into activeadmin:master Aug 22, 2012

@jpmckinney

This comment has been minimized.

Show comment Hide comment
@jpmckinney

jpmckinney Aug 22, 2012

Contributor

Merged. Hopefully no one creates a StatusTag model :P

Contributor

jpmckinney commented Aug 22, 2012

Merged. Hopefully no one creates a StatusTag model :P

jpmckinney added a commit that referenced this pull request Aug 23, 2012

@hron84

This comment has been minimized.

Show comment Hide comment
@hron84

hron84 Aug 28, 2012

Contributor

@jpmckinney if you fear from it, you can prefix classes with aa_ I do not thing AAStatusTag has a meaning, but in this form you can prefix ActiveAdmin's classes to prevent class collision :-)

Contributor

hron84 commented Aug 28, 2012

@jpmckinney if you fear from it, you can prefix classes with aa_ I do not thing AAStatusTag has a meaning, but in this form you can prefix ActiveAdmin's classes to prevent class collision :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment