Skip to content

Consistently use double quotes in ApplicationAgent template #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025
Merged

Consistently use double quotes in ApplicationAgent template #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b912a40
Consistently use double quotes in `ApplicationAgent` template
marcoroth Jul 28, 2025
1815b07
Remove duplicate ApplicationAgent tempalte
marcoroth Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/generators/active_agent/templates/application_agent.rb.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<% module_namespacing do -%>
class ApplicationAgent < ActiveAgent::Base
layout 'agent'
layout "agent"

generate_with :openai, model: "gpt-4o-mini", instructions: "You are a helpful assistant."
end
<% end %>
<% end %>
7 changes: 0 additions & 7 deletions lib/generators/erb/templates/application_agent.rb.tt
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion test/generators/active_agent/agent_generator_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class ActiveAgent::Generators::AgentGeneratorTest < Rails::Generators::TestCase

assert_file "app/agents/application_agent.rb" do |content|
assert_match(/class ApplicationAgent < ActiveAgent::Base/, content)
assert_match(/layout 'agent'/, content)
assert_match(/layout "agent"/, content)
end
end

Expand Down
2 changes: 1 addition & 1 deletion test/generators/active_agent/install_generator_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class ActiveAgent::Generators::InstallGeneratorTest < Rails::Generators::TestCas

assert_file "app/agents/application_agent.rb" do |content|
assert_match(/class ApplicationAgent < ActiveAgent::Base/, content)
assert_match(/layout 'agent'/, content)
assert_match(/layout "agent"/, content)
assert_match(/generate_with :openai/, content)
end
end
Expand Down