Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shell-lib (docker compose @v2) #76

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Update shell-lib (docker compose @v2) #76

merged 2 commits into from
Apr 21, 2023

Conversation

caffeinatedpixel
Copy link
Contributor

Pulls in activecm/shell-lib#32 to upgrade to docker compose v2

Zalgo2462
Zalgo2462 suggested changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@Zalgo2462 Zalgo2462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
It appears the switch to docker-compose v2 introduced a bug into the loop which waits on Kibana to come up. This error kept appearing and the installer got caught in the loop.

Zalgo2462
Zalgo2462 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@Zalgo2462 Zalgo2462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zalgo2462 Zalgo2462 merged commit c2b524d into master Apr 21, 2023
@Zalgo2462 Zalgo2462 deleted the update-shell-lib-apr-23 branch April 21, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zalgo2462 Zalgo2462 Zalgo2462 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caffeinatedpixel @Zalgo2462