New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed scans module from analysis, reporting, and config #281

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@lisaSW
Copy link
Collaborator

lisaSW commented Nov 28, 2018

@lisaSW lisaSW requested a review from ethack Nov 28, 2018

@lisaSW lisaSW added the needs review label Nov 29, 2018

@meljbruno
Copy link
Collaborator

meljbruno left a comment

Looks good!

@ethack

This comment has been minimized.

Copy link
Collaborator

ethack commented Dec 4, 2018

Note to self: I want to check what happens if using an older version of rita with this newer config file. If it breaks I think we might have to bump up a major version to indicate backwards incompatibility.

@ethack

This comment has been minimized.

Copy link
Collaborator

ethack commented Dec 4, 2018

With the Scanning section in the config commented out here is the behavior for an older rita version (v1.1.1).

rita test-config shows that ScanThreshold is set to 0.

Scanning:
  ScanThreshold: 0

This causes every connection to be reported in the scanning results (anything greater than 0 = everything). This isn't exactly an incompatible change, but it will definitely be a detriment to performance as it's basically a copy of the uconn collection into scans (again only in the situation of using an older version of rita with a newer config file).

@ethack ethack merged commit 9873fb2 into master Dec 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@meljbruno meljbruno removed the needs review label Dec 4, 2018

@ethack ethack deleted the 280-remove-scans-analysis branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment