New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hosts collection #294

Merged
merged 8 commits into from Dec 9, 2018

Conversation

Projects
None yet
2 participants
@lisaSW
Copy link
Collaborator

lisaSW commented Dec 8, 2018

lisaSW added some commits Dec 8, 2018

@lisaSW lisaSW requested review from ethack and meljbruno Dec 8, 2018

@lisaSW lisaSW changed the title 293 update hosts collection update hosts collection Dec 8, 2018

@lisaSW lisaSW changed the title update hosts collection Update hosts collection Dec 8, 2018

Ethan Robish
@ethack

ethack approved these changes Dec 8, 2018


res.DB.AggregateCollection(sourceCollectionName, ssn, pipeline)
// res.DB.AggregateCollection(sourceCollectionName, ssn, pipeline)

This comment has been minimized.

@ethack

ethack Dec 8, 2018

Collaborator

This is done somewhere else now?

)

//BuildIPv4Collection generates binary representations of the IPv4 addresses in the
//dataset for use in subnetting, address selection, etc.
func BuildIPv4Collection(res *resources.Resources) {

This comment has been minimized.

@ethack

ethack Dec 8, 2018

Collaborator

This same data is instead embedded in the hosts collection.


//BuildIPv6Collection generates binary representations of the IPv6 addresses in the
//dataset for use in subnetting, address selection, etc.
func BuildIPv6Collection(res *resources.Resources) {

This comment has been minimized.

@ethack

ethack Dec 8, 2018

Collaborator

IPv6 support is not yet ready, but when it is this data will live in the hosts collection.


//IPv4Binary provides a way to store a binary representation of an
//IPv4 address in MongoDB
IPv4Binary struct {

This comment has been minimized.

@ethack

ethack Dec 8, 2018

Collaborator

IPv4Binary is combined into Host

Ethan Robish

@ethack ethack force-pushed the 293-update-hosts-collection branch from c32a5ae to 9982873 Dec 8, 2018

@ethack ethack merged commit c4926f3 into 269-update-uconns-collection Dec 9, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@ethack ethack deleted the 293-update-hosts-collection branch Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment