From 89192923dfffd6fe09b0623bdfd31aa8198be078 Mon Sep 17 00:00:00 2001 From: Fariz Rahman Date: Thu, 7 Apr 2022 15:23:39 +0400 Subject: [PATCH] Set readonly=True by default on platform (#1583) --- hub/api/dataset.py | 10 +++++++--- hub/constants.py | 4 ++++ hub/core/dataset/dataset.py | 5 +++-- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/hub/api/dataset.py b/hub/api/dataset.py index 1323543112..583412d2c2 100644 --- a/hub/api/dataset.py +++ b/hub/api/dataset.py @@ -7,7 +7,11 @@ from hub.client.client import HubBackendClient from hub.client.log import logger from hub.core.dataset import Dataset, dataset_factory -from hub.constants import DEFAULT_MEMORY_CACHE_SIZE, DEFAULT_LOCAL_CACHE_SIZE +from hub.constants import ( + DEFAULT_MEMORY_CACHE_SIZE, + DEFAULT_LOCAL_CACHE_SIZE, + DEFAULT_READONLY, +) from hub.util.auto import get_most_common_extension from hub.util.bugout_reporter import feature_report_path, hub_reporter from hub.util.delete_entry import remove_path_from_backend @@ -32,7 +36,7 @@ class dataset: @staticmethod def init( path: str, - read_only: bool = False, + read_only: bool = DEFAULT_READONLY, overwrite: bool = False, public: bool = False, memory_cache_size: int = DEFAULT_MEMORY_CACHE_SIZE, @@ -209,7 +213,7 @@ def empty( @staticmethod def load( path: str, - read_only: bool = False, + read_only: bool = DEFAULT_READONLY, memory_cache_size: int = DEFAULT_MEMORY_CACHE_SIZE, local_cache_size: int = DEFAULT_LOCAL_CACHE_SIZE, creds: Optional[dict] = None, diff --git a/hub/constants.py b/hub/constants.py index 728f218899..6e3255e21b 100644 --- a/hub/constants.py +++ b/hub/constants.py @@ -128,3 +128,7 @@ _NO_LINK_UPDATE = "___!@#_no_link_update_###" SAMPLE_INFO_TENSOR_MAX_CHUNK_SIZE = 4 * MB + +DEFAULT_READONLY = ( + os.environ.get("HUB_DEFAULT_READONLY", "false").strip().lower() == "true" +) diff --git a/hub/core/dataset/dataset.py b/hub/core/dataset/dataset.py index d82ccfd6aa..fe3569108e 100644 --- a/hub/core/dataset/dataset.py +++ b/hub/core/dataset/dataset.py @@ -13,12 +13,13 @@ import numpy as np from hub.api.info import load_info from hub.client.log import logger -from hub.constants import FIRST_COMMIT_ID from hub.constants import ( + FIRST_COMMIT_ID, DEFAULT_MEMORY_CACHE_SIZE, DEFAULT_LOCAL_CACHE_SIZE, MB, SAMPLE_INFO_TENSOR_MAX_CHUNK_SIZE, + DEFAULT_READONLY, ) from hub.core.fast_forwarding import ffw_dataset_meta from hub.core.index import Index @@ -113,7 +114,7 @@ def __init__( storage: LRUCache, index: Optional[Index] = None, group_index: str = "", - read_only: bool = False, + read_only: bool = DEFAULT_READONLY, public: Optional[bool] = False, token: Optional[str] = None, verbose: bool = True,