Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CyberSource: Support 3DSecure requests #2624

Conversation

curiousepic
Copy link
Contributor

3 remote failures include pinless debit card tests which this commit is
not concerned with and a false alarm from overeager scrubbing assertion.

Remote:
39 tests, 180 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
92.3077% passed

Unit:
44 tests, 212 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

I'd appreciate a glance from @davidsantoso

3 remote failures include pinless debit card tests which this commit is
not concerned with and a false alarm from overeager scrubbing assertion.

Remote:
39 tests, 180 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
92.3077% passed

Unit:
44 tests, 212 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Copy link

@dtykocki dtykocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems straightforward.

@@ -363,6 +369,32 @@ def test_successful_retrieve_subscription
assert response.test?
end

def test_3ds_purchase_request
assert response = @gateway.purchase(1202, @three_ds_enrolled_card, @options.merge(payer_auth_enroll_service: true))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we have other gateways that send a similar, "check if the card is 3DS enabled" field and we've defaulted in Active Merchant? Not sure, but could be worth a check to see if there's a more or less default field we use for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's kinda difficult to determine, which probably means there's no standard. I think I'm in favor of keeping the option field verbatim to the actual request field sent until there's a more concerted effort to standardize.

Copy link
Member

@davidsantoso davidsantoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 !

@curiousepic curiousepic deleted the ENRG-7060_cybersource_3ds branch June 8, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants