New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against rails4 in travis-ci #687

Closed
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@sanemat
Contributor

sanemat commented May 11, 2013

  • Add gemfile for rails 4.0
  • Remove require active_support/core_ext/float/rounding.rb if activesupport 4
    • This file is dropped in rails4 (this is patch for ruby1.8)
  • Remove errors, add some rails4 features
    • config.secret_key_base
    • route match
  • Add travis-ci config

sanemat added some commits May 9, 2013

Add rails4.0gems
Add rails4
Use activeresource
Require unless activesupport v4
active_support/core_ext/float/rounding.rb is removed in rails4.
That patch about float for ruby1.8.
Add config.secret_key_base for rails4
This key is generated on my rake secret :)
Use :via option with route match method
Set :get or :post is better? I don't know yet.
@sanemat

This comment has been minimized.

Contributor

sanemat commented May 11, 2013

oops, rails2.3.

@sanemat

This comment has been minimized.

Contributor

sanemat commented May 11, 2013

works fine! and All green

@sanemat

This comment has been minimized.

Contributor

sanemat commented Jun 6, 2013

how about this?

@ntalbott ntalbott closed this in 372bab9 Jul 6, 2013

chengz added a commit to chengz/active_merchant that referenced this pull request Dec 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment