Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Apr 25, 2015
  1. @jonatack

    Merge join dependency specs

    jonatack authored
    Follow-up to f77b8e6
  2. @jonatack

    Fix typo [skip ci]

    jonatack authored
Commits on Apr 24, 2015
  1. @jonatack
Commits on Apr 14, 2015
  1. @jonatack
Commits on Apr 6, 2015
  1. @jonatack
Commits on Apr 5, 2015
  1. @jonatack
  2. @jonatack

    Add missing JoinDependency specs for Rails 4.1, 4.2, 5.0

    jonatack authored
    These 5 tests were removed in c489b22 while working on Polyamorous
    compatibility with Rails 4.1.
    
    They were not passing for Rails 4.1 at the time, which would explain
    the duplication of specs into two suites before/after Rails 4.1.
    
    In any case, they pass now since the recent refactoring, so it’s time
    to add them back.
    
    Next step:  We probably should be able to DRY the specs back into one
    suite again.
Commits on Apr 4, 2015
  1. @jonatack
  2. @jonatack
  3. @jonatack

    [WIP] Use requires & explicit files/folders to remove duplication

    jonatack authored
    and fix JoinDependency#make_joins with Active Record 4.2 and 5.0.
Commits on Apr 3, 2015
  1. @jonatack

    Use prepend for Ruby 2.0 and up

    jonatack authored
    - prepend is a private method in 2.0 so we have to use `send(:prepend)`
    
    - `defined?(Module.prepend)` returns non-nil only in Ruby 2.2, so check
    RUBY_VERSION instead
    
    - wrap lines at 80 characters
  2. @jonatack

    `self.included` needs to be `self.prepended` here

    jonatack authored
    as revealed by missing specs that will soon be added.
    
    Follow-up to f4bdf8e.
  3. @jonatack
  4. @jonatack
  5. @jonatack

    Purely cosmetic code churn :trollface:

    jonatack authored
    Wrap code at 80 chars so I can read it! and other formatting to
    facilitate reading and working on the code.
Commits on Apr 2, 2015
  1. @jonatack

    Module#prepend for newer Rubies/Rails

    jonatack authored
    Module#prepend is supposed to be a cleaner way of injecting code than
    alias_method, so let’s give it a try with Rails 4.1 and up with Ruby
    versions that support #prepend.
  2. @jonatack

    Gemfile: load Arel only for Rails master

    jonatack authored
    and use newer hash syntax.
Commits on Mar 31, 2015
  1. @jonatack

    Use alias_method instead of alias_method_chain

    jonatack authored
    since the latter is deprecated in Rails master targeting 5.0.0.
    
    This should eliminate the annoying deprecation warnings in the console
    :)
  2. @jonatack

    Add Ruby version to specs info header

    jonatack authored
    and use a local variable for the line display.
Commits on Mar 30, 2015
  1. @jonatack

    Removed unneeded Rails 3 code

    jonatack authored
    from files required only with Rails 4.1 and up.
  2. @jonatack

    Add file titles & more readability formatting

    jonatack authored
    with line wrap at 80 chars and newer hash syntax.
    
    This helps for reading and understanding the code on smaller screens.
  3. @jonatack

    Use a common local variable

    jonatack authored
    and, while we’re at it, single quotes.
  4. @jonatack

    Wrap lines at 80 chars for readability

    jonatack authored
    on smaller screens, use parentheses around method arguments, and `do …
    end` instead of curly braces `{ … }` for multi-line blocks.
  5. @jonatack

    Specify Ruby 2.2.1 in travis-ci

    jonatack authored
    Ruby 2.2.1 was released on March 3 as a bug patch release, but the
    Travis mirrors are still serving 2.2.0 when 2.2 is specified.
Commits on Mar 29, 2015
  1. @jonatack

    `silence_stream` is not thread-safe

    jonatack authored
    and deprecated in Rails 4.2.1 and 5.
    
    This was also causing the Travis CI tests to fail with Rails master.
    
    Replace with `ActiveRecord::Migration.verbose = false`
  2. @jonatack

    Use Ruby 1.9 hash syntax

    jonatack authored
  3. @jonatack

    Display database and AR/Arel versions

    jonatack authored
    when running tests.
Commits on Jan 29, 2015
  1. @jonatack

    Merge pull request #15 from chrismar035/patch-1

    jonatack authored
    Add license to gemspec
  2. @jonatack
Commits on Jan 22, 2015
  1. @chrismar035

    Add license to gemspec

    chrismar035 authored
Commits on Jan 2, 2015
  1. @jonatack
  2. @jonatack
Commits on Dec 13, 2014
  1. @jonatack
  2. @jonatack

    Update travis-ci

    jonatack authored
    - Add `sudo: false` following advice from travis-ci
    - Specify minor Ruby versions to use latest patch level
    - Add Rails 4-2-stable
Commits on Dec 10, 2014
  1. @jonatack
Something went wrong with that request. Please try again.