New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check exact matches before splitting #449

Merged
merged 1 commit into from Oct 17, 2014

Conversation

Projects
None yet
3 participants
@joeyates
Contributor

joeyates commented Oct 17, 2014

  • if the supplied name contains 'and' or 'or' we should check
    if it exists before splitting and checking the parts, this way we
    handle 'terms_and_conditions' as well as pairs of fields like
    'name_and_email'.
Check exact matches before splitting
* if the supplied name contains '_and_' or '_or_' we should check
  if it exists before splitting and checking the parts, this way we
  handle 'terms_and_conditions' as well as pairs of fields like
  'name_and_email'.

jonatack added a commit that referenced this pull request Oct 17, 2014

Merge pull request #449 from joeyates/master
Allow attributes containing `and` or `or` by checking exact matches before splitting.

@jonatack jonatack merged commit 397b581 into activerecord-hackery:master Oct 17, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jonatack

This comment has been minimized.

Show comment
Hide comment
@jonatack

jonatack Oct 17, 2014

Member

@joeyates Good idea, thank you 😃

A follow-up PR to add this to the change log would be great.

Member

jonatack commented Oct 17, 2014

@joeyates Good idea, thank you 😃

A follow-up PR to add this to the change log would be great.

@seanlinsley

This comment has been minimized.

Show comment
Hide comment
@seanlinsley

seanlinsley Oct 18, 2014

Contributor

😻 thanks for this! This resolves #299

Contributor

seanlinsley commented Oct 18, 2014

😻 thanks for this! This resolves #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment