Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Memory Leak #1606

Closed
attila-lin opened this issue Jul 15, 2020 · 2 comments · Fixed by #1609
Closed

Possible Memory Leak #1606

attila-lin opened this issue Jul 15, 2020 · 2 comments · Fixed by #1609

Comments

@attila-lin
Copy link

Your issue may already be reported!
Please search on the Actix Web issue tracker before creating one.

Expected Behavior

The memory usage should be stable.

Current Behavior

The memory usage keeps growing.

image

the red one is using actix-web 3.0.0-alpha.3, the yellow one is actix-web 3.0.0-beta.1

Possible Solution

No idea.

Steps to Reproduce (for bugs)

Sorry for cant provide a minimal reproduction.

Context

Your Environment

  • Rust Version (I.e, output of rustc -V): rustc 1.46.0-nightly (16957bd4d 2020-06-30)
  • Actix Web Version: 3.0.0-beta.1
@robjtede
Copy link
Member

It's very difficult for us to investigate reports of memory leaks without any sort of example.

At the very least, we need much more information about what code paths to check: OS, system or custom allocator, HTTP 1 or 2, TLS (and which one) or not, middleware used, other notable features used, other crates used, how many req/s does this server deal with?

Even better if you're not able to provide the code would be if you are able to profile the allocations yourself.

@morphy2k
Copy link

This could be the same memory issue that I casually mentioned in #1607 yesterday.

I've just made 100,000,000 requests with 200 concurrent connections against the root endpoint in my example. The memory consumption was less than 500KB at the beginning, after the benchmark was finished it was almost 800MB.

I'm still a Rust newbie, but if I can help in any way, for example further testing, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants