Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codecoverage for tests and examples #1299

Merged

Conversation

godofdream
Copy link
Contributor

Codecov checks Codecoverage for bench and tests folders.
By excluding these files from codecoverage we show more correct codecoverage statistics.

@godofdream godofdream changed the title No codecoverage for tests and examples Remove codecoverage for tests and examples Jan 21, 2020
codecov.yml Outdated Show resolved Hide resolved
This reverts commit 3cb231a.
@godofdream
Copy link
Contributor Author

I removed the "codecov:" line.

@codecov-io
Copy link

Codecov Report

Merging #1299 into master will decrease coverage by 2.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1299      +/-   ##
==========================================
- Coverage   80.47%   77.93%   -2.54%     
==========================================
  Files         159      146      -13     
  Lines       18541    16980    -1561     
==========================================
- Hits        14921    13234    -1687     
- Misses       3620     3746     +126
Impacted Files Coverage Δ
tests/test_server.rs 50.65% <0%> (-46.48%) ⬇️
actix-http/src/encoding/decoder.rs 59.82% <0%> (-12.51%) ⬇️
src/test.rs 75.94% <0%> (-8.02%) ⬇️
src/web.rs 84.61% <0%> (-7.7%) ⬇️
awc/src/sender.rs 53.91% <0%> (-6.09%) ⬇️
awc/src/request.rs 75.73% <0%> (-3.31%) ⬇️
actix-http/src/encoding/encoder.rs 69.17% <0%> (-3.01%) ⬇️
actix-http/src/client/h2proto.rs 72.28% <0%> (-2.41%) ⬇️
actix-http/src/response.rs 83.7% <0%> (-0.89%) ⬇️
actix-http/src/h1/encoder.rs 83.58% <0%> (-0.6%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a5b62b...1254035. Read the comment docs.

@JohnTitor JohnTitor merged commit e17b3ac into actix:master Jan 23, 2020
@JohnTitor
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants