Add convenience functions for testing#1401
Merged
Merged
Conversation
Member
|
Looks good! Could you also update changelog? |
Contributor
Author
|
Yeah, I can. |
Member
|
master should fix the build, could you rebase? |
pfrenssen
reviewed
Apr 5, 2020
Comment on lines
+1146
to
+1147
| #[actix_rt::test] | ||
| async fn test_body_json() { |
There was a problem hiding this comment.
Since the function is called read_body_json() it is probably a good idea to call this test test_read_body_json().
Member
There was a problem hiding this comment.
It's the same as read_response_json and test_response_json, we can follow-up later.
JohnTitor
approved these changes
Apr 5, 2020
JohnTitor
left a comment
JohnTitor
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding tests and fixing remarks from #1398