Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor websocket key hashing #2035

Merged
merged 4 commits into from Feb 28, 2021
Merged

refactor websocket key hashing #2035

merged 4 commits into from Feb 28, 2021

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Feb 28, 2021

PR Type

Refactor

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

WebSocket key hashing does not allocate String.

@robjtede robjtede added B-semver-major breaking change requiring a major version bump A-awc project: awc A-http project: actix-http A-actors project: actix-web-actors labels Feb 28, 2021
@robjtede robjtede requested review from a team February 28, 2021 01:15
Copy link
Member

@ibraheemdev ibraheemdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

actix-http/examples/ws.rs Outdated Show resolved Hide resolved
actix-http/examples/ws.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@fakeshadow fakeshadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-actors project: actix-web-actors A-awc project: awc A-http project: actix-http B-semver-major breaking change requiring a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants