Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document actix-web-codegen #108

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@svenstaro
Copy link
Member

commented Aug 5, 2019

This fixes #105

content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
examples/getting-started/src/main.rs Outdated Show resolved Hide resolved
@vmalloc

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

Thanks for the PR! I think some small fixes are needed - commented on the changes directly

@svenstaro

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

Great points overall. The only thing I didn't do as you said is having the same route path. I think it's confusing for users if they want to just copy that into their code as then the paths would overlap. However, I added a path that's more in line with the current paths shown in the examples so that it should be an easy concept to grasp.

content/docs/getting-started.md Outdated Show resolved Hide resolved
@vmalloc

vmalloc approved these changes Aug 6, 2019

@svenstaro svenstaro merged commit 29d1d51 into master Aug 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@svenstaro svenstaro deleted the document-actix-web-codegen branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.