Include __builtin__.h in correct path #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to test this by manually installing the produced .deb, before we merge this PR. |
This reverts commit 3e61d15.
plajjan
force-pushed
the
326-fix-builtin-include
branch
from
ad8ee42
to
2e6af1d
Compare
|
I've verified the .deb installed version works correctly! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #286, which introduced a regression. The benefit of that was slightly more elegant Makefiles. The downside was hairy relative import... it didn't feel good at the time but I did merge it. Turns out it caused more problems, thus I'm reverting it.
I think these are mostly signs that our C files are not entirely well structured. These imports between builtin/* and builtin are not good. Spaghetti-ish.
Fixes #326.