Reorganize modules #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plajjan
force-pushed
the
97-reorganize-modules
branch
from
cdb4e9f
to
701e8c2
Compare
This moves two of the standard library modules, math and time, into the modules directory. They have previously been split out as the modules directory acted both as a source and output location of actonc compilation. That changed when we introduced the dist directory, to which we write output - it then acts as the working directory of actonc. The modules directory in the source git repository is now used for source files and is not a working directory for actonc. Thus, we move our standard library modules in there. numpy is currently an exception as it consists of many files and is inevitably much more compliated to compile, thus it remains as a separate directory. I suspect most modules will follow the simpler pattern of time and math, where .act, .h and .c file all have the same prefix. Let's wait and see, if this turns into crap will come up with some other structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves two of the standard library modules, math and time, into the
modules directory. They have previously been split out as the modules
directory acted both as a source and output location of actonc
compilation. That changed when we introduced the dist directory, to
which we write output - it then acts as the working directory of actonc.
The modules directory in the source git repository is now used for
source files and is not a working directory for actonc. Thus, we move
our standard library modules in there.
numpy is currently an exception as it consists of many files and is
inevitably much more compliated to compile, thus it remains as a
separate directory. I suspect most modules will follow the simpler
pattern of time and math, where .act, .h and .c file all have the same
prefix. Let's wait and see, if this turns into crap will come up with
some other structure.
Closes #97.